search

ZerioDev / Music-bot

A complete code to download for a cool Discord music bot !
https://discord.gg/5cGSYV8ZZj
GNU General Public License v3.0
864 stars 1.05k forks source link

Bot never disconnects from Voice channel (24/7 feature) #246

Closed monckey100 closed 1 month ago

monckey100 commented 1 year ago

Added configs so it's optional and added some other features this bot was missing from the main repo.

pendragons-code commented 1 year ago

Hey what the heck why was this PR not accepted? Seems to have some good stuff here lmao.

monckey100 commented 1 year ago

Thank you, I think the devs might not be looking at PRs, I did open a discord ticket. Maybe give them a nudge for me?

pendragons-code commented 1 year ago

Believe me i tried pushing for another feature in the past, only to get an incoherent response.

pendragons-code commented 1 year ago

Thank you, I think the devs might not be looking at PRs, I did open a discord ticket. Maybe give them a nudge for me?

how did that go?

monckey100 commented 1 year ago

Thank you, I think the devs might not be looking at PRs, I did open a discord ticket. Maybe give them a nudge for me?

how did that go?

They never got back to me and actively ignore my comments, so I'm just making my own fixes

pendragons-code commented 1 year ago

Thank you, I think the devs might not be looking at PRs, I did open a discord ticket. Maybe give them a nudge for me?

how did that go?

They never got back to me and actively ignore my comments, so I'm just making my own fixes

damn. i mean they also get a bunch of shit PRs so i guess that is understandable. but your PR in particular looks really good.

revot334 commented 1 year ago

Thank you, I think the devs might not be looking at PRs, I did open a discord ticket. Maybe give them a nudge for me?

how did that go?

They never got back to me and actively ignore my comments, so I'm just making my own fixes

we have not actively ignored you. This project has had a rough year please be patient. I am taking over maintaining this project. Please make sure this code works with the current version of discord-player (6.1.1). and I would be happy to approve once V8 comes out and this code is working with that code base.

monckey100 commented 1 year ago

Thank you, I think the devs might not be looking at PRs, I did open a discord ticket. Maybe give them a nudge for me?

how did that go?

They never got back to me and actively ignore my comments, so I'm just making my own fixes

we have not actively ignored you. This project has had a rough year please be patient. I am taking over maintaining this project. Please make sure this code works with the current version of discord-player (6.1.1). and I would be happy to approve once V8 comes out and this code is working with that code base.

Hello, this version works with discord-player v5, I have also patched the v5 version so it can continue to work. I did this as some servers do not support the newest node and thus newest discord-player v6.

pendragons-code commented 1 month ago

Woahhhh

revot334 commented 1 month ago

Woahhhh

???

Nickeldon commented 1 month ago

Woahhhh

The code is outdated

I can try to redo the code to see if it works and quote the OP (I give the credits) on that