search

ZerioDev / Music-bot

A complete code to download for a cool Discord music bot !
https://discord.gg/5cGSYV8ZZj
GNU General Public License v3.0
895 stars 1.09k forks source link

config.js should be in .gitignore #323

Closed BoredKevin closed 4 months ago

BoredKevin commented 5 months ago

Hi there, I think that the config.js file should be added to the .gitignore file to ensure that important variables containing sensitive information are not tracked by Git and are not pushed to the remote repository.

Some people run this bot by forking it and since config.js isn't a standard way of keeping secrets, I think it should be important to add it to .gitignore

LND237 commented 4 months ago

It may be a good idea to create a .env. file containing all the sensitive data and pass it to the config.js for the default configuration template.

BoredKevin commented 4 months ago

Great idea, an implementation of this already exists on SudhanPlayz/Discord-MusicBot

LND237 commented 4 months ago

Ill create a quick PR

BoredKevin commented 4 months ago

Hey there @ZerioDev, please merge #324

LND237 commented 4 months ago

@BoredKevin the #324 was merged so this issue is no longer relevant.

BoredKevin commented 4 months ago

Thank you for the quick fix, I'm glad I brought this to attention. This issue has now been resolved.

LND237 commented 4 months ago

Glad to help.