search

Zero-1729 / volt

Volt Wallet
MIT License
53 stars 6 forks source link

fix: add sample env #6

Closed Jeezman closed 1 month ago

Jeezman commented 1 month ago

Description

Running the app in development mode fails with this error:

error: modules/env.ts: /volt-wallet/modules/env.ts: "BREEZ_INVITE_CODE" is not defined in .env
> 1 | import {BREEZ_INVITE_CODE, BREEZ_SDK_API_KEY} from '@env';
    |         ^^^^^^^^^^^^^^^^^
  2 |
  3 | // Path: modules/env.ts
  4 | export const _BREEZ_INVITE_CODE_ = BREEZ_INVITE_CODE;

Adding a .env file fixes the issue

Added a sample env, also updated the readme to that effect

Jeezman commented 1 month ago

@Zero-1729 Seems this commit fixes this.

Zero-1729 commented 1 month ago

Thank you @Jeezman for surfacing this and the PR.

I've cleaned up some more of the Greenlight credentials code and included a section in the README on how to store that info in the .env. Nevertheless, I'd like to merge this to include your env.example and info about copying those placeholder contents to .env.

Please rebase this PR, then test against https://github.com/Zero-1729/volt/commit/b55b4be1d939a202ff92a68099c8b8dc3f383c81 on main and drop any additional feedback.

Jeezman commented 1 month ago

Thank you @Jeezman for surfacing this and the PR.

I've cleaned up some more of the Greenlight credentials code and included a section in the README on how to store that info in the .env. Nevertheless, I'd like to merge this to include your env.example and info about copying those placeholder contents to .env.

Please rebase this PR, then test against b55b4be on main and drop any additional feedback.

@Zero-1729 All good. Rebase here https://github.com/Zero-1729/volt/pull/6/commits/682527311189359f6d165793649c184806364d53