search

Zero-1729 / volt

Volt Wallet
MIT License
53 stars 6 forks source link

Unable to add wallet #7

Closed Jeezman closed 4 weeks ago

Jeezman commented 1 month ago

Unable to add wallet during development setup

screenshot

Screenshot 2024-06-07 at 16 51 53

Error message on terminal

 LOG  [Error Catch]  [Error: Error: Could not parse descriptor tr(xprv9zC8agyvKuyfJ6iGFaaLNpTtjjQambiGfSnRzF2vX59V1veWQB8ZxzHRBMoEpbdjZgFjjJQUMwSXzQ7XZmr5v8n4nin5hPRRmgb4fXHyYJe/86'/0'/0'/0/*)]

 ERROR  [AsyncStorage] (Add wallet) Error loading data: Error: Could not parse descriptor

I think the error is as a result of the default account being set to unified ie Lightning (BIP86)

Zero-1729 commented 1 month ago

This is due to the descriptor library, bitcoinerlab/descriptors, I believe. Volt currently requires a patch which enables it to parse taproot descriptors (tr()) using the library. The proper fix is for the patch I have opened to be merged upstream.

For now, manually editing the files in the PR for the bitcoinerlab/descriptors in the node_modules should resolve this problem. Hope this helps.

Jeezman commented 1 month ago

This is due to the descriptor library, bitcoinerlab/descriptors, I believe. Volt currently requires a patch which enables it to parse taproot descriptors (tr()) using the library. The proper fix is for the patch I have opened to be merged upstream.

For now, manually editing the files in the PR for the bitcoinerlab/descriptors in the node_modules should resolve this problem. Hope this helps.

Got it. Thoughts on building your fork and adding it as the dependency url?

"@bitcoinerlab/descriptors": "https://github.com/Zero-1729/descriptors.git",

I forked and built your patch on a personal repo and it worked. Lmk what you think

Zero-1729 commented 4 weeks ago

Yeah, fair enough, just switched to my fork for the time being; will be part of the next tagged release (v0.4.4-beta.1).

Will revert back to the upstram repo once the PR has been merged.