ZeroCM / zcm

Zero Communications and Marshalling
http://zerocm.github.io/zcm/
GNU Lesser General Public License v2.1
233 stars 67 forks source link

Update waf arch to debian arch mapping for additional DEST_CPU types #430

Closed jhoellerbauer closed 3 months ago

jhoellerbauer commented 1 year ago

waf deduces the DEST_CPU type by running echo | <compiler> -dM -E - and extracting information from the default #defines added by the compiler. The validity of this method is questionable since it is possible that multiple of the search terms waf looks for can be found in the output (for example both thumb and arm are often defined at the same time). See https://waf.io/apidocs/_modules/waflib/Tools/c_config.html for the source code.

I verified that thumb corresponds to armhf by using a docker container built to run on a beagle bone black (a arm/v7l platform): docker run --rm -it --net=host balenalib/beaglebone-black-ubuntu bash

and then comparing the output of dkpg --print-architecture and the above command that waf uses.

However, there is no guarantee this mapping is correct. thumb is an instruction set subtype and armhf is a term mostly made up by debian. It is possible there could be devices that identify as thumb in waf that won't be able to run debian armhf packages. But after some research, that likelihood seems very small.

jbendes commented 3 months ago

Closing due to inactivity