ZeroIntensity / view.py

The Batteries-Detachable Web Framework
https://view.zintensity.dev
MIT License
206 stars 15 forks source link

Migrate test suite to Pytest #164

Closed ZeroIntensity closed 1 month ago

ZeroIntensity commented 2 months ago

Description:

Ward has been great, but using it over Pytest makes #109 more or less impossible. Pytest and Ward are pretty similar, but most developers are familiar with Pytest anyway, so this change will probably be for the best.

tallhypnosis commented 2 months ago

I could work on this, if you want me to ?

ZeroIntensity commented 2 months ago

That would be great! Most of this issue will just be adding pytest.mark.asyncio and renaming the functions.

If you need to me to set up the changes to the actions workflow, I can do that for you. Nobody likes messing with workflow files.

tallhypnosis commented 2 months ago

sure

ZeroIntensity commented 1 month ago

Any progress here?

tallhypnosis commented 1 month ago

done with the changes

On Sat, May 11, 2024, 10:01 PM Peter @.***> wrote:

Any progress here?

— Reply to this email directly, view it on GitHub https://github.com/ZeroIntensity/view.py/issues/164#issuecomment-2105947804, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUDWDJG764DAMJ4TCO7YK3DZBZBXBAVCNFSM6AAAAABHHNJG4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVHE2DOOBQGQ . You are receiving this because you were assigned.Message ID: @.***>

ZeroIntensity commented 1 month ago

Great! Go ahead and make a PR, I'll update the workflows if you haven't already

tallhypnosis commented 1 month ago

before i make the PR is there anything to mind or any suggestion ?

tallhypnosis commented 1 month ago

Do you want me to change something in the readme or any doc file ?

ZeroIntensity commented 1 month ago

Nope, I got it.