Closed ZeroIntensity closed 1 month ago
I could work on this, if you want me to ?
That would be great! Most of this issue will just be adding pytest.mark.asyncio
and renaming the functions.
If you need to me to set up the changes to the actions workflow, I can do that for you. Nobody likes messing with workflow files.
sure
Any progress here?
done with the changes
On Sat, May 11, 2024, 10:01 PM Peter @.***> wrote:
Any progress here?
— Reply to this email directly, view it on GitHub https://github.com/ZeroIntensity/view.py/issues/164#issuecomment-2105947804, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUDWDJG764DAMJ4TCO7YK3DZBZBXBAVCNFSM6AAAAABHHNJG4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVHE2DOOBQGQ . You are receiving this because you were assigned.Message ID: @.***>
Great! Go ahead and make a PR, I'll update the workflows if you haven't already
before i make the PR is there anything to mind or any suggestion ?
Do you want me to change something in the readme or any doc file ?
Nope, I got it.
Description:
Ward has been great, but using it over Pytest makes #109 more or less impossible. Pytest and Ward are pretty similar, but most developers are familiar with Pytest anyway, so this change will probably be for the best.