search

ZeroIntensity / view.py

The Batteries-Detachable Web Framework
https://view.zintensity.dev
MIT License
206 stars 15 forks source link

Linting and Static Type Checking #73

Closed rjwignar closed 8 months ago

rjwignar commented 8 months ago

This resolves #34.

Summary of Changes

This Pull Request adds the following features:

Linter Choice

I researched both flake8 and ruff and ultimately decided on ruff due to its pyproject.toml configuration support, which is not currently supported by flake8.

Please let me know if you agree with this decision.

Addition as Optional Dependencies

I decided to include ruff and mypy as optional dependencies (under [project.optional-dependencies] -> dev) rather than as a core dependency (under [project]) as these dependencies will support development and testing rather than production.

The project can be installed with these dependencies included by running:

pip install .[dev]

Other Changes

Please let me know if changes to this PR are required.

Additionally, if this PR is approved and merged, I would like this contribution to count towards my Hacktoberfest 2023 progress. If the above changes are approved and merged, could the hacktoberfest-accepted label be added to the PR/MR?

Thank you for considering these changes.

netlify[bot] commented 8 months ago

Deploy Preview for viewpy ready!

Name Link
Latest commit 77d0fdfe0177306b84be51694db4f93c6db1f7fd
Latest deploy log https://app.netlify.com/sites/viewpy/deploys/653c852f4ce1900008198de5
Deploy Preview https://deploy-preview-73--viewpy.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.