search

ZeroK-RTS / Zero-K-Infrastructure

Website, lobby launcher and server, steam deployment, .NET based tools and other vital parts of Zero-K infrastructure
GNU General Public License v3.0
53 stars 52 forks source link

Have the wrapper detect and inform chobby about ATI #1642

Closed GoogleFrog closed 7 years ago

GoogleFrog commented 7 years ago

According to this https://springrts.com/mantis/view.php?id=5494 bumpmapped water has known crashes with ATI cards and I doubt anyone is going to fix it. The wrapper should detect ATI so that chobby can enable some ATI compatibility setting to set ugly water.

ashdnazg commented 7 years ago

Wouldn't it be better to just expose video card info to lua in the engine?

Licho1 commented 7 years ago

Yeah I think it's easier if card is exposed to lua, since it's already detected. This has to happen before crashy stuff is loaded though.

Licho1 commented 7 years ago

Yeah we should expose it from engine as @ashdnazg says. Make a mantis food, it mantis fails to devour it, I will implement it, in that case reopen @GoogleFrog

gajop commented 7 years ago

Time travel: https://github.com/spring/spring/commit/960b7a64fe9d0246a0207c8b3c71844c8be9a0b3#commitcomment-21433042

gajop commented 7 years ago

Also I think it's unnecessary to provide wrapper functionalities that come from parsing infolog.txt, unless engine crashes when starting the menu. That can be (and already often is) done in Lua.

Licho1 commented 7 years ago

Wrapper would not parse infolog, wrapper would implement its own detection and possibly change settings so that there are no crashes.