Open GoogleFrog opened 7 years ago
I don't think its a false positive.. It had to crash after saying it exits fine.. Crash detection does not use any parsing, it's plain old simple process information provided by operating system.
i didn't fully investigate, but the exit code isn't used here: https://github.com/ZeroK-RTS/Zero-K-Infrastructure/blob/284635276686c8db645a6aac5563f6383674f2bc/ChobbyLauncher/Program.cs#L156
also the infolog.txt in #455 seems to contain sensitive data like "AuthToken", "Friends", etc. these should be removed in uploaded infolog.txt.
Auth token is one time only so its not very sensitible. But I havent tested whether it can be reused or not. We should probabl yhide it.
var isCrash = process.ExitCode != 0; Is it possible that spring returns non zero return code @abma ?
It could crash after printing the message. Without knowing the "real" exit code its difficult to investigate this. chobby should log the exit code it gets from spring.
The wrapper crash detection contains some false positives. Here is an example https://github.com/ZeroK-RTS/CrashReports/issues/455