search

ZeroK-RTS / Zero-K-Infrastructure

Website, lobby launcher and server, steam deployment, .NET based tools and other vital parts of Zero-K infrastructure
GNU General Public License v3.0
53 stars 52 forks source link

Crash false positives #1658

Open GoogleFrog opened 7 years ago

GoogleFrog commented 7 years ago

The wrapper crash detection contains some false positives. Here is an example https://github.com/ZeroK-RTS/CrashReports/issues/455

Licho1 commented 7 years ago

I don't think its a false positive.. It had to crash after saying it exits fine.. Crash detection does not use any parsing, it's plain old simple process information provided by operating system.

abma commented 7 years ago

i didn't fully investigate, but the exit code isn't used here: https://github.com/ZeroK-RTS/Zero-K-Infrastructure/blob/284635276686c8db645a6aac5563f6383674f2bc/ChobbyLauncher/Program.cs#L156

also the infolog.txt in #455 seems to contain sensitive data like "AuthToken", "Friends", etc. these should be removed in uploaded infolog.txt.

abma commented 7 years ago

https://github.com/ZeroK-RTS/CrashReports/search?q=AuthToken

Licho1 commented 7 years ago

Auth token is one time only so its not very sensitible. But I havent tested whether it can be reused or not. We should probabl yhide it.

Licho1 commented 7 years ago

var isCrash = process.ExitCode != 0; Is it possible that spring returns non zero return code @abma ?

abma commented 7 years ago

https://github.com/spring/spring/blob/918cabae4a2ccbeb33244b23c264ecb5d63b0fdd/rts/System/SpringApp.cpp#L913

It could crash after printing the message. Without knowing the "real" exit code its difficult to investigate this. chobby should log the exit code it gets from spring.