Check Treaty Effects

[GoogleFrog]

I have modified the database to contain the following treaty effects:

• Dropship Access: Allows the recipient to attack and send dropships through the wormhole network of the benefactor.
• Bomber Access: Allows the recipient to send bombers through the wormhole network of the benefactor.
• Ceasefire: Prevents the benefactor from taking hostile action (sending ships or invasion) against the planets of the recipient.
• Influence Freeze: Prevents influence from the benefactor spreading to planets of the recipient.
• Defensive Pact: Enables commanders from the benefactor faction to join in the defense of planets of the recipient. Prevents the benefactor from launching invasions and ships at the recipient.
• Alliance: Prevents all hostilities, allows commanders to aid the defense of the recipient and bestows full wormhole network access.
• Invasion Staging Point: Gives the recipient a forward base on a planet through which they can launch invasions and dropships.
• Bomber Staging Point: Gives the recipient a forward base on a planet so they can lauch bombers from the planet.
• Avoid Planet: Prevents the benefactor from launching invasions or ships at the planet
• Ignore Planet: Prevents the benefactors influence from spreading onto the planet.
• Defend Planet: Enables commanders from the benefator faction to join the defense of a particular planet. Prevents the benefactor from launching invasions or ships at the planet.
• Metal: Transfers metal once
• Dropships: Transfers dropships once
• Bombers: Transfers bombers once
• Warp Cores: Transfers warp cores once
• Victory Points: Transfers victory points once
• Influence: Transfers influence once
• Metal per turn: Give metal per turn
• Energy per turn: Give energy per turn
• Dropships per turn: Give dropships per turn
• Bombers per turn: Give bombers per turn
• Warp Cores per turn: Give warp cores per turn
• Victory Points per turn: Give victory points per turn
• Influence per turn: Give influence per turn

These effects are configured in the database in the way that makes sense but I am not sure that they do what I said they do. The code should be checked to make sure that benefactor and recipient are not the wrong way around. If the code has places where it is the wrong way around I think the code should be changed for consistency. The consistency rule is that the benefactor of an effect is always the one giving something to the recipient, whether it be resources, extra wormhole access, safety from being attacked or aid in defense.

[GoogleFrog]

The Defend Planet, Bomber Staging Point and Invasion Staging Point are treaty effects that did not previously exist. They can be defined in the database in a coherent way but the mechanics for them may not be implemented properly.