ZeroK-RTS / Zero-K-Infrastructure

Website, lobby launcher and server, steam deployment, .NET based tools and other vital parts of Zero-K infrastructure
GNU General Public License v3.0
53 stars 52 forks source link

Wrapper reports failure for map-type mod download #2757

Closed GoogleFrog closed 3 years ago

GoogleFrog commented 4 years ago

Host a custom room with game Unit Level Ups v5. This appears to have been uploaded to the ZK site via the map/mod upload box, however I cannot find it on the site. Since it is a game, chobby first tries to download it with RAPID. When this fails, chobby tries to download it with MAP, as I was told that this is how to get games that were uploaded to the ZK site. When chobby does this, wrapperFunctions.DownloadFinished responds like this:

[f=-000001] DownloadFinished, Unit Level Ups v5, RAPID, false, false
[f=-000001] DownloadFinished, Unit Level Ups v5, MAP, false, false

This causes players to need to rejoin the room after joining it, as otherwise the lobby doesn't know that the download was a success.

Licho1 commented 4 years ago

Root cause is probably not having the mod marked as mod internally in ZK site, this should be fixed - possible when we upload it we can detect if its a map or mod and categorize properly.

GoogleFrog commented 3 years ago

Also mods cannot be found.

image

maackey commented 3 years ago
        // filter only maps
        ret = db.Resources.Where(x => x.TypeID == ResourceType.Map);

Maps filter explicitly only includes resources of type Map on this page.

Are mods exclusively going to be map-mods? If not I'd like to perhaps create a different page/interface for them -- Maps / Replays / Mods.

Licho1 commented 3 years ago

Ok first - for downloader it should just download it using game/mod mode. The second part - what do we show on website is tougher. There are tens of thousands "mods" stored there, every single test build of ZK and other RAPID games.

We should filter those that depend on "rapid://zk:stable" this will show actual ZK mods. I agree we should hae entire new section with mods for this.