search

ZeroK-RTS / Zero-K-Infrastructure

Website, lobby launcher and server, steam deployment, .NET based tools and other vital parts of Zero-K infrastructure
GNU General Public License v3.0
53 stars 52 forks source link

Sorting Ladder by other columns does not work #2778

Closed Birdulon closed 3 years ago

Birdulon commented 3 years ago

Clicking on the heading does everything you'd expect - makes an up or down arrow next to it, rewrites the url to include &grorder=Tru&grdesc=True and refreshes the page. Everything except actually sorting by that column. image

The same happens with the Player column, and probably Ladder Rating too, though that would be equivalent to Rank anyway for sorting purposes.

Birdulon commented 3 years ago

I've checked the other uses of UniGrid and all of the ones I can access apart from the Ladder and Map Ladder are perfectly functional. The only common factor I can think of is the True Rating field having a more complex value (two numbers) than any of the other data models contain.

DeinFreund commented 3 years ago

I didn't intend for sorting to work here, ladders are usually expected to be in a fixed order. I suppose it would be nice if the UI didn't suggest that it's sortable.

Licho1 commented 3 years ago

Yeah if you don't set "SetSort" it should not show as sortable by default.