search

ZeroK-RTS / Zero-K-Infrastructure

Website, lobby launcher and server, steam deployment, .NET based tools and other vital parts of Zero-K infrastructure
GNU General Public License v3.0
53 stars 52 forks source link

Require one extra vote for resign polls to pass #2799

Closed Legomenon-gh closed 3 years ago

Legomenon-gh commented 3 years ago

This change makes resign require unanimous approval for small team games (up to 4v4) and makes resign a little harder for large team games, but can be tweaked depending on the exact desired behavior.

Based on feedback in https://zero-k.info/Battles/Detail/1060977

I've sanity checked this to work for 1 and 2 players but haven't fully tested past that, I will do that once I have sign off (it should work fine, but arithmetic errors are embarrassing and testing with 4 accounts locally is a pain)

GoogleFrog commented 3 years ago

As I said on the post, I like the idea.

Legomenon-gh commented 3 years ago

Yeah I wasn't sure if you liked the idea for small teams alone or all games, but at least it should be simple to tweak moving forward.

This has been tested more properly now

Licho1 commented 3 years ago

I think that for big games, we should instead ask only people who are not resigned already. Often people who already resigned vote to resign the rest so that they can have another game.

GoogleFrog commented 3 years ago

I think that for big games, we should instead ask only people who are not resigned already. Often people who already resigned vote to resign the rest so that they can have another game.

Agreed. People would complain initially about having a few players left extending the game, but in that case the resigners should either not resign or accept that people are happy with playing on and seeing the explosions.

Legomenon-gh commented 3 years ago

I'm not sure if this is general talk or feedback on this PR, but I am not changing the large team game behavior since I cannot test it locally and this is separate from the "player can be forcefully resigned out of a 3v3/4v4" problem

GoogleFrog commented 3 years ago

I think the scope of this PR is good.