Add sanity check on map ban insertion

ZeroK-RTS / Zero-K-Infrastructure

Website, lobby launcher and server, steam deployment, .NET based tools and other vital parts of Zero-K infrastructure

GNU General Public License v3.0

53 stars 52 forks source link

Add sanity check on map ban insertion #2801

Closed Legomenon-gh closed 3 years ago

Legomenon-gh commented 3 years ago

The check on the maximum map ban length on update was dropped after a refactor, this commit reapplies it. The map banner will not apply bans past a maximum threshold (currently 75%) so inserting excess bans will not break matchmaker but would give the player a couple of extra bans.

Legomenon-gh commented 3 years ago

Just noticed this bug, apologies. A quick check on the database would be good to trim any existing extra map bans (I doubt anybody would bother making custom POST requests on purpose to do this, but there could always be a bug somewhere too)

sprunk commented 3 years ago

@Anarchid or @Aquanim ping for SQL

DeinFreund commented 3 years ago

I suppose this means nothing has to be done?

sprunk commented 3 years ago

Seems so, thanks