search

ZeroK-RTS / Zero-K-Infrastructure

Website, lobby launcher and server, steam deployment, .NET based tools and other vital parts of Zero-K infrastructure
GNU General Public License v3.0
53 stars 52 forks source link

Tweaks to vote margin requirement #2811

Closed Legomenon-gh closed 3 years ago

Legomenon-gh commented 3 years ago

I'm not super happy with this implementation (it's a bit ugly), but it's marginally better than what was there so it might be worth a pull request (it makes it easier to make limited changes to poll thresholds in the future). Feel free to reject it though, I'd prefer a broader refactor but can't justify the risk vs reward ratio.

https://github.com/ZeroK-RTS/Zero-K-Infrastructure/commit/9f659704e25239216b952876ba9858188e595f53 is based on forum comments (I personally have no stakes on large team games). I'm happy to take it out if making resign universally harder is considered a good change.

Addresses https://github.com/ZeroK-RTS/Zero-K-Infrastructure/issues/2808

Legomenon-gh commented 3 years ago

https://github.com/ZeroK-RTS/Zero-K-Infrastructure/commit/9f659704e25239216b952876ba9858188e595f53 should be irrelevant pretty soon since the game will likely be handling resign votes instead of the server.

Not sure if the first commit is worth keeping around, feel free to close the PR