ZeroK-RTS / Zero-K-Infrastructure

Website, lobby launcher and server, steam deployment, .NET based tools and other vital parts of Zero-K infrastructure
GNU General Public License v3.0
53 stars 52 forks source link

Wrapper event for externally launched spring crashing #2820

Closed GoogleFrog closed 3 years ago

GoogleFrog commented 3 years ago

If we are to have general players run s benchmark to test whether the new engine works, then chobby needs a way to detect crashes for externally launched springs. The only non-hacky way I can think of doing this is if the wrapper sends an event upon the externally launched spring closing, with a parameter for whether it has crashed.

Dumping the entire infolog back to chobby via the wrapper when the launched spring closes would be great too, as it would help with finding issues.

I thought I made a ticket for this but can't find it.

Licho1 commented 3 years ago

crashes are now reported as normal

GoogleFrog commented 3 years ago

I don't see the part of the commit where a message is sent to chobby, can you point me to it? What does the event look like and what has to be added to the loopback?

Licho1 commented 3 years ago

added the message

    [ChobbyMessage]
    public class NewSpringExited
    {
        public string StartScriptContent { get; set; }
        public string StartDemoName { get; set; }
        public string SpringSettings { get; set;  }
        public string Engine { get; set; }
        public string CustomId { get; set;  } 
        public bool IsCrash { get; set; }
    }