Lingering wrong battle player counts after leaving battles

[GoogleFrog]

Enter an empty autohost, then leave it. The last BattleUpdate sent by the server about the battle will say that there is one player in it.

[GoogleFrog]

[t=02:12:31.329242][f=-000001] [ClientMessage] JoinBattle {"BattleID":3688} [t=02:12:31.574617][f=-000001] [ServerMessage] User {"AccountID":15114,"Avatar":"chicken_dragon","BanMute":false,"BanVotes":false,"BanSpecChat":false,"BattleID":3688,"Clan":"RSN","Country":"AU","DisplayName":"GoogleFrog","Faction":"Empire","IsAdmin":true,"IsBot":false,"LobbyVersion":"Chobby","Name":"GoogleFrog","SteamID":"76561198005614529","Badges":["dev_adv","donator_1"],"Icon":"7_7","IsAway":false,"IsInBattleRoom":true,"IsInGame":false,"EffectiveMmElo":2922,"EffectiveElo":2859,"Level":156,"Rank":7} [t=02:12:31.804338][f=-000001] LeaveBattle sent while not in battle [t=02:12:31.804415][f=-000001] [ClientMessage] JoinBattle {"BattleID":3688} [t=02:12:31.870620][f=-000001] [chobby] Showing battle with ID, 3688 [t=02:12:31.887301][f=-000001] [ClientMessage] UpdateUserBattleStatus {"Name":"GoogleFrog","Sync":1} [t=02:12:31.888827][f=-000001] [ClientMessage] UpdateUserBattleStatus {"IsSpectator":false,"Name":"GoogleFrog","Sync":1,"AllyNumber":0} [t=02:12:31.892975][f=-000001] [ServerMessage] JoinBattleSuccess {"BattleID":3688,"Bots":[],"Options":{"option_notes":"== Next Version Beta ==\nReport issues, summary below.\n \nNew Bombers\n - Penguin (220m): Light strike bomber. Low damage (360), shoots like Scalpel, hits air.\n - Odin (1500m): High damage bomb (18k) that all mobile units can dodge. Manual fire shoots temporary shields.\n \nAir changes:\n - Sparrow can boost to reveal an area\n - Revamped Krow gun. DPS and brake rate buffs.\n - Raptor aims wider and turns faster\n - Slightly buffed Locust and Thunderbird.\n \nOther changes:\n - More HP for Knight, Ravager, Hermit.\n - Zephyr shoots misiles as well.\n - Improve DRP turning and spin.","noelo":"1","minspeed":"1","maxspeed":"1"},"Players":[{"AllyNumber":0,"IsSpectator":false,"QueueOrder":785,"Name":"GoogleFrog","Sync":0,"JoinTime":"2023-11-16T04:59:34.2989869-08:00"}],"MapOptions":{}} [t=02:12:32.171352][f=-000001] [chobby] Showing battle with ID, 3688 [t=02:12:32.182940][f=-000001] [ClientMessage] UpdateUserBattleStatus {"Name":"GoogleFrog","Sync":1} [t=02:12:32.184448][f=-000001] [ClientMessage] UpdateUserBattleStatus {"IsSpectator":false,"Name":"GoogleFrog","Sync":1,"AllyNumber":0} [t=02:12:32.188235][f=-000001] [ServerMessage] JoinBattleSuccess {"BattleID":3688,"Bots":[],"Options":{"option_notes":"== Next Version Beta ==\nReport issues, summary below.\n \nNew Bombers\n - Penguin (220m): Light strike bomber. Low damage (360), shoots like Scalpel, hits air.\n - Odin (1500m): High damage bomb (18k) that all mobile units can dodge. Manual fire shoots temporary shields.\n \nAir changes:\n - Sparrow can boost to reveal an area\n - Revamped Krow gun. DPS and brake rate buffs.\n - Raptor aims wider and turns faster\n - Slightly buffed Locust and Thunderbird.\n \nOther changes:\n - More HP for Knight, Ravager, Hermit.\n - Zephyr shoots misiles as well.\n - Improve DRP turning and spin.","noelo":"1","minspeed":"1","maxspeed":"1"},"Players":[{"AllyNumber":0,"IsSpectator":false,"QueueOrder":785,"Name":"GoogleFrog","Sync":0,"JoinTime":"2023-11-16T04:59:34.2989869-08:00"}],"MapOptions":{}} [t=02:12:32.408757][f=-000001] [ServerMessage] UpdateUserBattleStatus {"AllyNumber":0,"IsSpectator":false,"QueueOrder":785,"Name":"GoogleFrog","Sync":1,"JoinTime":"2023-11-16T04:59:34.2989869-08:00"} [t=02:12:32.411092][f=-000001] [ServerMessage] UpdateUserBattleStatus {"AllyNumber":0,"IsSpectator":false,"QueueOrder":785,"Name":"GoogleFrog","Sync":1,"JoinTime":"2023-11-16T04:59:34.2989869-08:00"} [t=02:12:32.691484][f=-000001] [ServerMessage] UpdateUserBattleStatus {"AllyNumber":0,"IsSpectator":false,"QueueOrder":785,"Name":"GoogleFrog","Sync":1,"JoinTime":"2023-11-16T04:59:34.2989869-08:00"} [t=02:12:32.694038][f=-000001] [ServerMessage] UpdateUserBattleStatus {"AllyNumber":0,"IsSpectator":false,"QueueOrder":785,"Name":"GoogleFrog","Sync":1,"JoinTime":"2023-11-16T04:59:34.2989869-08:00"} [t=02:12:33.557531][f=-000001] [ClientMessage] LeaveBattle {"BattleID":3688} [t=02:12:33.755471][f=-000001] [ServerMessage] BattleUpdate {"Header":{"BattleID":3688,"PlayerCount":1,"SpectatorCount":0}} [t=02:12:34.036737][f=-000001] [ServerMessage] User {"AccountID":15114,"Avatar":"chicken_dragon","BanMute":false,"BanVotes":false,"BanSpecChat":false,"Clan":"RSN","Country":"AU","DisplayName":"GoogleFrog","Faction":"Empire","IsAdmin":true,"IsBot":false,"LobbyVersion":"Chobby","Name":"GoogleFrog","SteamID":"76561198005614529","Badges":["dev_adv","donator_1"],"Icon":"7_7","IsAway":false,"IsInBattleRoom":false,"IsInGame":false,"EffectiveMmElo":2922,"EffectiveElo":2859,"Level":156,"Rank":7} [t=02:12:34.038970][f=-000001] [ServerMessage] BattleUpdate {"Header":{"BattleID":3688,"Map":"MoonQ10x"}} [t=02:12:36.097158][f=-000001] [SpringApp::MainEventHandler][SDL_WINDOWEVENT_MOVED][1] di=2, ssx=1920, ssy=1080, wsx=1049, wsy=851, wpx=431, wpy=60 [t=02:12:36.111364][f=-000001] [SpringApp::MainEventHandler][SDL_WINDOWEVENT_MOVED][2] di=2, ssx=1920, ssy=1080, wsx=1920, wsy=1009, wpx=1920, wpy=23 [t=02:12:36.111379][f=-000001] [SpringApp::MainEventHandler][SDL_WINDOWEVENT_SIZE_CHANGED][1] fullScreen=0 [t=02:12:36.111571][f=-000001] [GR::UpdateGLConfigs] [t=02:12:36.111583][f=-000001] [GR::UpdateGLGeometry][1] winSize=<1920,1009> [t=02:12:36.111666][f=-000001] [GR::UpdateScreenMatrices] vpx=1920.000000, vpy=48.000000, vsx=1920.000000, vsy=1009.000000, ssx=1920.000000, ssy=1080.000000, screenPosX=1920, screenPosY=0 [t=02:12:36.111674][f=-000001] [GR::UpdateGLGeometry][2] winSize=<1920,1009> [t=02:12:36.111680][f=-000001] [GR::InitGLState] [t=02:12:36.117259][f=-000001] [GR::LogDisplayMode] display-mode set to 1920x1009x24bpp@60Hz (windowed::decorated) [t=02:12:36.117279][f=-000001] [~ScopedOnceTimer][GlobalRendering::UpdateGL] 5ms [t=02:12:36.119056][f=-000001] [~ScopedOnceTimer][ActiveController::ResizeEvent] 1ms [t=02:12:36.119065][f=-000001] [SpringApp::MainEventHandler][SDL_WINDOWEVENT_SIZE_CHANGED][2]

[t=02:12:36.119072][f=-000001] [t=02:12:36.119075][f=-000001] [SpringApp::MainEventHandler][SDL_WINDOWEVENT_SHOWN][1] fullScreen=0 [t=02:12:36.119093][f=-000001] [~ScopedOnceTimer][Sound::Iconified] 0ms [t=02:12:36.119100][f=-000001] [SpringApp::MainEventHandler][SDL_WINDOWEVENT_SHOWN][2]

[t=02:12:37.250751][f=-000001] [ServerMessage] MatchMakerStatus {"MatchMakerEnabled":false,"QueueCounts":{"Sortie":0,"Battle":0,"Coop":0,"1v1":0,"1v1 Narrow":0,"1v1 Wide":0},"InstantStartQueues":[],"IngameCounts":{"Sortie":0,"Battle":0,"Coop":0,"1v1":0,"1v1 Narrow":0,"1v1 Wide":0},"UserCount":48,"UserCountDiscord":4471} [t=02:12:38.781404][f=-000001] [ServerMessage] BattleUpdate {"Header":{"BattleID":3688,"PlayerCount":0,"SpectatorCount":0}} [t=02:12:43.809597][f=-000001] LeaveBattle sent while not in battle [t=02:12:43.809681][f=-000001] [ClientMessage] JoinBattle {"BattleID":3688} [t=02:12:44.057365][f=-000001] [ServerMessage] User {"AccountID":15114,"Avatar":"chicken_dragon","BanMute":false,"BanVotes":false,"BanSpecChat":false,"BattleID":3688,"Clan":"RSN","Country":"AU","DisplayName":"GoogleFrog","Faction":"Empire","IsAdmin":true,"IsBot":false,"LobbyVersion":"Chobby","Name":"GoogleFrog","SteamID":"76561198005614529","Badges":["dev_adv","donator_1"],"Icon":"7_7","IsAway":false,"IsInBattleRoom":true,"IsInGame":false,"EffectiveMmElo":2922,"EffectiveElo":2859,"Level":156,"Rank":7} [t=02:12:44.341127][f=-000001] [chobby] Showing battle with ID, 3688 [t=02:12:44.357637][f=-000001] [ClientMessage] UpdateUserBattleStatus {"Name":"GoogleFrog","Sync":1} [t=02:12:44.359345][f=-000001] [ClientMessage] UpdateUserBattleStatus {"IsSpectator":false,"Name":"GoogleFrog","Sync":1,"AllyNumber":0} [t=02:12:44.364627][f=-000001] [ServerMessage] JoinBattleSuccess {"BattleID":3688,"Bots":[],"Options":{"option_notes":"== Next Version Beta ==\nReport issues, summary below.\n \nNew Bombers\n - Penguin (220m): Light strike bomber. Low damage (360), shoots like Scalpel, hits air.\n - Odin (1500m): High damage bomb (18k) that all mobile units can dodge. Manual fire shoots temporary shields.\n \nAir changes:\n - Sparrow can boost to reveal an area\n - Revamped Krow gun. DPS and brake rate buffs.\n - Raptor aims wider and turns faster\n - Slightly buffed Locust and Thunderbird.\n \nOther changes:\n - More HP for Knight, Ravager, Hermit.\n - Zephyr shoots misiles as well.\n - Improve DRP turning and spin.","noelo":"1","minspeed":"1","maxspeed":"1"},"Players":[{"AllyNumber":0,"IsSpectator":false,"QueueOrder":786,"Name":"GoogleFrog","Sync":0,"JoinTime":"2023-11-16T04:59:46.7798871-08:00"}],"MapOptions":{}} [t=02:12:44.602418][f=-000001] [ServerMessage] UpdateUserBattleStatus {"AllyNumber":0,"IsSpectator":false,"QueueOrder":786,"Name":"GoogleFrog","Sync":1,"JoinTime":"2023-11-16T04:59:46.7798871-08:00"} [t=02:12:44.856779][f=-000001] [ServerMessage] UpdateUserBattleStatus {"AllyNumber":0,"IsSpectator":false,"QueueOrder":786,"Name":"GoogleFrog","Sync":1,"JoinTime":"2023-11-16T04:59:46.7798871-08:00"} [t=02:12:45.628879][f=-000001] [ClientMessage] LeaveBattle {"BattleID":3688} [t=02:12:45.875811][f=-000001] [ServerMessage] User {"AccountID":15114,"Avatar":"chicken_dragon","BanMute":false,"BanVotes":false,"BanSpecChat":false,"Clan":"RSN","Country":"AU","DisplayName":"GoogleFrog","Faction":"Empire","IsAdmin":true,"IsBot":false,"LobbyVersion":"Chobby","Name":"GoogleFrog","SteamID":"76561198005614529","Badges":["dev_adv","donator_1"],"Icon":"7_7","IsAway":false,"IsInBattleRoom":false,"IsInGame":false,"EffectiveMmElo":2922,"EffectiveElo":2859,"Level":156,"Rank":7} [t=02:12:46.169004][f=-000001] [ServerMessage] BattleUpdate {"Header":{"BattleID":3688,"Map":"Prestige v1.00"}}

[GoogleFrog]

[sprunk]

Perhaps related? #2948

[GoogleFrog]

This seems like the most suspicious part.

[t=02:12:33.557531][f=-000001] [ClientMessage] LeaveBattle {"BattleID":3688} [t=02:12:33.755471][f=-000001] [ServerMessage] BattleUpdate {"Header":{"BattleID":3688,"PlayerCount":1,"SpectatorCount":0}