search

ZeroK-RTS / Zero-K-Infrastructure

Website, lobby launcher and server, steam deployment, .NET based tools and other vital parts of Zero-K infrastructure
GNU General Public License v3.0
53 stars 52 forks source link

!voteresign didn't work in this game: #427

Closed xponen closed 9 years ago

xponen commented 9 years ago

http://zero-k.info/Battles/Detail/327256

me and my ally had !voteresign in ally chat and global chat, but the server just didn't respond. Also, GoogleFrog visited the game briefly, not sure what GoogleFrog saw, but he left early.

let4be commented 9 years ago

https://github.com/ZeroK-RTS/Zero-K-Infrastructure/issues/266

xponen commented 9 years ago

Also related: http://zero-k.info/Forum/Thread/11659

In my case it didnt respond at all. Maybe in https://github.com/ZeroK-RTS/Zero-K-Infrastructure/issues/266 springie forgot all command because its restarted. Just a guess

let4be commented 9 years ago

I suspect the reason: when someone quits the room, !voteresign stops working for this team(and also !voteexit it seems) we had all the evening with this bug yesterday

xponen commented 9 years ago

Found suspected code. Will add in check to handle player who disconnected from Springie while ingame

For reference: https://github.com/ZeroK-RTS/Zero-K-Infrastructure/blob/master/Springie/Springie/autohost/Polls/VoteResign.cs#L26

Will also go check if all other !vote code need same fix...

Licho1 commented 9 years ago

Just please no more stupid hacks like changing the vote code.. there is a context that contains all the data about game. Whole springie needs rethinkg,redesign also for quickmatch, don't fix this symptom only without looking at big picture.

xponen commented 9 years ago

Is not too much hack Licho1,

Voteresign read player list from Spring, but it also ask Springie whether player is AFK. IMO this check can be skipped if player disconnect from lobby because their lobby can't tell Springie if they are AFK anymore.

But okay, I'll go check more detail, to be safe, in case I miss something.

let4be commented 9 years ago

Good job @xponen :) I really hope this thing will be fixed, it's super annoying