search

ZeroK-RTS / Zero-K

Open source RTS game running on the Spring/Recoil engine
https://zero-k.info
GNU General Public License v2.0
690 stars 207 forks source link

Set Nanoframe Death Feature Team #1305

Closed GoogleFrog closed 8 years ago

GoogleFrog commented 8 years ago

[7:18 PM] Rafal[ZK] random bug i noticed: debris left after killing a nanoframe shows "noname" in tooltip instead of player name [7:19 PM] Rafal[ZK] while debris left after killing funnly built units shows correct player name [7:19 PM] Rafal[ZK] fully built*

https://springrts.com/mantis/bug_report.php

sprunk commented 8 years ago

Not dev engine I think? This has been happening for ages.

sprunk commented 8 years ago

Looks like that callout doesn't actually work.

CarabusX commented 8 years ago

Wasn't dev engine btw.

GoogleFrog commented 8 years ago

Dev engine tag was to wait to revisit when dev engine changes.

GoogleFrog commented 8 years ago

Also there is no way that setting the AllyTeam of a feature is going to make the tooltip widget able to read the features Player Name correctly.

sprunk commented 8 years ago

It's tested and works. There were two patches, first one added the team (https://github.com/ZeroK-RTS/Zero-K/commit/d30198c1d26bb57c486d3cff9dd358bdc737ade6) but apparently the tooltip checks for allyteam too so this was added in the second (https://github.com/ZeroK-RTS/Zero-K/commit/4c10a2a0338d37edd81f54b6d56b8cce4163963b).

Won't need revisiting because it already works (but not closing in case you meant something else).

CarabusX commented 8 years ago

Glad that my suggestion to set proper allyTeam in addition to just team, worked :)

GoogleFrog commented 8 years ago

Ah, the commits have the same name.