ZeroK-RTS / Zero-K

Open source RTS game running on the Spring/Recoil engine
https://zero-k.info
GNU General Public License v2.0
671 stars 204 forks source link

Bomber Selector design #1337

Open sprunk opened 8 years ago

sprunk commented 8 years ago

See https://github.com/ZeroK-RTS/Zero-K/pull/1336

Needs some design decisions:

dvr333 commented 8 years ago

By "moving" I assume you mean bombers with orders, rather than bombers that are just flying in a holding pattern around the airpad/factory.

CrazyEddieTK commented 8 years ago

@dvr333 - Yes, I assume that's what he means as well.

"should moving bombers count as idle?" - I don't use the terminology "idle", because that has a specific meaning in Spring-talk: a unit with no pending orders. Instead I use the terms "ready" or "ready and untasked". I don't intend for these to be official terms, I'm just using them here (and in the code) to clarify the intent behind this hotkey.

The intent is to select bombers that haven't yet been given a target to attack, so that you can give them a target to attack. Bombers with Move orders but no Attack orders are - in most circumstances - going to be good candidates for giving targets to attack. I talk about this a bit more here.

"should there be a clickable icon?" - I think there should be. I'll submit another PR later for this. I'm still working on an assortment of improvements to this selector function.

"where exactly should it live in its submenu?" - For the time being I put it under Game/Selection Hotkeys, in the "Misc ZK uikeys" section (along with "Hawks" and "Mobile non-builders" and "Append non-ctrl grouped"). That menu might need an overhaul, but until that happens it's probably as good a place to put it as any.