search

ZeroK-RTS / Zero-K

Open source RTS game running on the Spring/Recoil engine
https://zero-k.info
GNU General Public License v2.0
691 stars 207 forks source link

Bad smoke pieces #1867

Open GoogleFrog opened 7 years ago

GoogleFrog commented 7 years ago

Anyone with free time can improve the smoke pieces of many units. These cases are usually very offcenter, limited to only part of the unit or are spawned deep within so make the smoke not look particularly severe. Some bug is preventing some units from smoking at all. Some bos -> LUS is required to fix smoking while cloaked.

~No smoke at all: Aspis, Swift, Hawk, Thunderbird, Krow, Grizzly, Spider Factory, Jack, Firewalker, Skuttle, Ultimatum, Mariner, Hunter, Zephyr, Aegis,~

Awful: Fusion, Raven, Gunship Plant, Hovercraft Platform, Shipyard, Protector, Silencer,

Subpar: Mex, Solar, Geo, Caretaker, Shieldbot Factory, Dirtbag, Cloakybot Factory, Warrior, Vehicle Factory, Leveler, Airplane Plant, Wyvern, Vulture, Banshee, Rapier, Brawler, Vindicator, Penetrator, Flail, Amph Bot, Duck, Archer, Buoy, Scallop, Angler, Weaver, Hermit, Tarantula, Archangel, Welder, Reaper, Pillager, Dante, Catapult, Funnelweb, Chainsaw, Zenith

~Important smoke while cloaked: Conjuror, Gremlin, Flea,~

Redone, for review: Adv Geo,

Lack of smoke from Seawolf and Scylla makes sense.

Anarchid commented 7 years ago

The evo emitter thing allows Scylla and Seawolf to emit bubbles. Ideally this should also apply to sinking wreckage.

GoogleFrog commented 7 years ago

I think I don't want bubbles or smoke for underwater things. They are somewhat stealthy.

Anarchid commented 7 years ago

They are mostly "cannot be targeted even if you know its there" stealthy, though. And they wouldn't bubble when not damaged!

Smoking underwater wreckages is a separate issue, i guess, as it requires a different tool to solve and doesn't impinge on any stealthiness.

GoogleFrog commented 7 years ago

You can see underwater wreckages so I don't mind if they smoke.

sprunk commented 7 years ago

Related to the wrecks side discussion https://github.com/spring/spring/pull/286

sprunk commented 7 years ago

https://github.com/ZeroK-RTS/Zero-K/commit/c523aaa821c6dc9c3fd37c0bbe1965abbd15ea1a - everything should now smoke (perhaps some of these are still awful though).

GoogleFrog commented 7 years ago

Do '/luarules give' and '/luarules damage' to see all units smoking. At a glance Fusion and Solar are poor.