Minimap issues

[maackey]

1.) Minimap overlays Settings menu (obscuring controls) #2691 2.) Opacity setting of 0 is equivalent to opacity setting of 1 3.) Opacity only affects Minimap border when zoomed in, it is unclear that it affects the minimap when zoomed out as it isn't under the sub section "Minimap fading when zoomed out" 4.) "Map buttons on the right" and "Minimizable" don't appear to do anything. 5.) "Resizeable" seems redundant as the minimap can be resized in ctrl+f11 menu regardless of this setting (which is obscured depending on border/map aspect ratio) 6.) The minimap viewport preview is slightly larger than what actually appears on screen. (default camera) https://github.com/spring/spring/commit/5f3465bf79a1a7cf90eb2485a6a6fa2057ed0c2a

[sprunk]

5) Tweak mode is an undocumented power-user feature that the average user won't know about so I think this is fine. 6) Engine issue. https://springrts.com/mantis/view.php?id=5962

[maackey]

Issue part 5 was separated from 4 because I only found the resize handle after editing the map in tweak mode -- the minimap hides the resize toggle otherwise.

I see two mutually exclusive fixes for issue 5: 1.) Remove the resize handle entirely (and let tweak mode handle minimap size) 2.) Draw the resize handle over / outside the minimap.

BTW, I'm not able to add labels -- these are all relatively minor and strictly related to the UI.

[Histidine91]

IIRC 5) exists specifically because Licho wants to be able to resize minimap on the fly, without going into tweakmode.

[sprunk]

6 improved (as much as it's going to be) https://github.com/spring/spring/commit/5f3465bf79a1a7cf90eb2485a6a6fa2057ed0c2a

[GoogleFrog]

Apart from possibly some settings issues, I do not see any problems here. I am not convinced that the settings you have issues with don't do anything.

Ctrl+F11 cannot resize the minimap under the default settings so "resizable" is really not redundant.

[maackey]

I am not convinced that the settings you have issues with don't do anything.

They may very well do something, but it is not at all obvious what, so at the very least the descriptions should be updated if they do in fact work, so a player would know where to look for the changes.

Ctrl+F11 cannot resize the minimap under the default settings so "resizable" is really not redundant.

Isn't the whole point of the tweak mode to be able to move and resize UI components? Having a separate option to resize just the minimap seems awfully redundant to me.

I do not see any problems here

They're not huge game breaking bugs -- but they are issues nonetheless. Fiddling with the settings is really annoying when you can't tell what the settings do or if it doesn't appear that they do what they should.

edit: formatting