search

ZeroK-RTS / Zero-K

Open source RTS game running on the Spring/Recoil engine
https://zero-k.info
GNU General Public License v2.0
695 stars 209 forks source link

Build range 3D undefined for all non-flying constructors #3174

Open DeinFreund opened 6 years ago

DeinFreund commented 6 years ago

This leads to caretakers having spherical range for building units, but cylindrical range for building buildings. In order to avoid this inconsistency, it would make sense to clearly define this attribute in the unitdefs instead of having the engine decide.

Dante not being assisted below cliff: example

Singu being assisted below cliff: example2

sprunk commented 6 years ago

Sounds like an engine bug. Build range 3D is supposed to work regardless of what the target is.

ArchShaman commented 6 years ago

Related?: http://zero-k.info/Battles/Detail/583368

DeinFreund commented 6 years ago

Even if it's an engine bug, could we still define it in the unitdef first? It was not clear to me, that caretakers were supposed to use spherical build range. The patrol command doesn't seem to know about this either, as it still gives repair commands within a cylinder and fails.

sprunk commented 6 years ago

As far as I can tell all units are already defined to use 2D buildrange (not defined in ZK but engine defaults to 2D anyway). I suspect the culprit is this lame nano thing.

DeinFreund commented 6 years ago

Has this been reported to engine?

sprunk commented 6 years ago

I made a Spring PR (389) but it got stuck.

sprunk commented 6 years ago

In case the PR gets closed here's a mantis ticket: https://springrts.com/mantis/view.php?id=4084

DeinFreund commented 6 years ago

When given the repair order manually they assist properly

I don't remember this being the case here.