Add patrol, fight, and move commands to structures that morph into mobiles

[dvr333]

When morphing into a mobile unit, it's kindof annoying that you can't queue move commands until after the unit has finished morphing. Ideally, when the morph order is underway, the command card would change to the to-be-morphed unit to allow for order queuing during construction, just like with factory units under construction. If the morph is cancelled, then the commands would just get cancelled as well.

[GoogleFrog]

I think it would be sufficient to give static units move, fight, and patrol if they are morphing into a mobile unit. Many commands check their validity on AllowCommand so would also need to check whether a structure has the command on CommandFallback. It may be best to create some fake queuing commands, especially in the case of engine commands.

[GoogleFrog]

See https://github.com/ZeroK-RTS/Zero-K/commit/8204e486e979c9b8c114dc5b7ea5afe20b68090f

[dvr333]

Cool, if that exposes the Move command when morphing (I'm not super familiar with how unitdefs are interpreted), then that's a huge chunk of the way there. Being able to Patrol/Fight is nice, but to me the priority thing is to have some way to get the Sparrow moving the moment it's ready.

Okay, tested it out. It certainly works. Shame the button shows when unmorphed and not morphing, I suppose that's an engine limitation.

[GoogleFrog]

Is it a shame? It isn't an engine limitation. I was midway through implementing adding/removal when I lost any sense of the purpose of what I was doing. How can a move command for the radar tower hurt people?

• You may accidentally select your radar tower and give it a move order, resulting in an ugly leftover order. Selection hierarchies make this difficult to do.
• A new player may see that the radar tower has a move command, yet find that it does nothing. This could be a little confusing, but seems like a minor issue. Hopefully the player would realise the purpose of the move order upon discovering the morph command.

A permanent move command seems good.

• The code is a lot simpler.
• It no longer matters the order in which players issue the move and morph order. This could come up when someone simultaneously left clicks to issue the move order with one hand and presses M with the other hand.
• Technically, a unit cannot morph while it is under construction. Instead, the morph is queued. Adding the move command whenever the unit is queued to morph makes the rules for adding (and removing) the move command even weirder.

[GoogleFrog]

The move command was so easy to add because it is a lua command. Patrol and Fight are built-in commands and likely have sanity checks that prevent them automatically appearing for static units.

[dvr333]

That makes sense.