ZeroK-RTS / Zero-K

Open source RTS game running on the Spring/Recoil engine
https://zero-k.info
GNU General Public License v2.0
696 stars 210 forks source link

Investigate why Steel_Blue had broken F1 view before BAR engine #3677

Open GoogleFrog opened 5 years ago

GoogleFrog commented 5 years ago

https://i.imgur.com/oeuUcbi.jpg

lhog commented 5 years ago

Looks like something else along the line of https://github.com/ZeroK-RTS/Zero-K/pull/3620 and https://github.com/ZeroK-RTS/Zero-K/pull/3669

It's puzzling to see that so many cases popped up since recently. The bugs were there forever, but only started to pop up after some ZK or engine change. Frankly I have no idea what change might have caused that. Anyway SteelBlue will need to follow a tedious path of finding the offending widget: http://zero-k.info/Forum/Thread/28600

SteelBlueZK commented 5 years ago

my testimony:

At the start of the game I see only red(when heightmap is active). After some condition is met, the colors change to what they should be. The condition is the ground changing height, or being affected. for example, rouge misiles or merlin misiles deform ground, so when their attacks impact I get heightmap over the explosion area. a mex explosion also does that. Larget buildings, like factories/singus, update underneath their footprint, and smaller buildings, like LLt/picket do not. These rules follow line of sight, so I need to see the modified terrain before I get heightmap.

I also have a video https://streamable.com/og2fl https://www.youtube.com/watch?v=VU0DqTU0I5g

Placeholder seems to adjust terrain too.

https://github.com/ZeroK-RTS/CrashReports/issues/23239

I certainly didn't notice it before, but there's a sliver of color on the North edge of the map.


thinking it's an engine bug, Ihog has guided me to do engine launches in a strange way. https://media.discordapp.net/attachments/278908415756206080/606195914914267158/unknown.png?width=711&height=623 https://media.discordapp.net/attachments/278908415756206080/606196443501428765/unknown.png?width=690&height=623

engine 104.0.1-1318-g8cf4dea works and engine 104.0.1-1322-gd3b03b5 is bork

SteelBlueZK commented 5 years ago

I did not realise that the engine updates happened already. Still have issue https://streamable.com/s1lj2 engine 104.0.1-1333-gce618bd

https://github.com/ZeroK-RTS/CrashReports/issues/23412 this is the infodump of the session I played with the video,just in case.

SteelBlueZK commented 2 years ago

Bar engine does not have broken F1 view. recommend close.

lhog commented 2 years ago

Check you have no PBO disabled, something like UsePBO=0 in your infolog/springsettings. The thing is I wasn't fixing anything in this regard. Either PBO is disabled or it got fixed "accidentally"

lhog commented 2 years ago

N2S. Two likely suspects:

https://github.com/beyond-all-reason/spring/commit/6ef7975279d1ba8cbde2e5389f76e66c5116c393 https://github.com/beyond-all-reason/spring/commit/6b5abe65ab7b1cf70eac0ffc94d048da0ec0f8e7

SteelBlueZK commented 2 years ago

UsePBO = 0

in steamapps\common\Zero-K\_springsettings.cfg Also in springsettings.cfg I don't know why there's underscore springsettings and just springsettings.

lhog commented 2 years ago

No idea too, but you can see the actually used value in infolog.txt. 99% sure it's going to be UsePBO = 0. It would likely take 20 min to fix the bug if I had AMD GPU at hand, but otherwise I can only go by educated guesswork, so I'm not sure how to proceed. if you want to help the fellow AMD folks hit me up on Discord (ivand) and I can make a few aforementioned educated guesses and send binaries to you for testing, otherwise UsePBO = 0 is fine by me for now.

SteelBlueZK commented 2 years ago

[t=00:00:02.310272][f=-000001] SetSettings Value, UsePBO, 1 SetSettings Value, UsePBO, 0 appears 6 times. Looks like UsePBO = 0 is aggresively set so that changing the value in springsettings.cfg didn't change my game. https://github.com/ZeroK-RTS/CrashReports/issues/55273

Screenshot from my end showing my view is right. https://cdn.discordapp.com/attachments/432874986064052235/941698428793151488/unknown.png

GoogleFrog commented 2 years ago

I think compat mode sets pbo to 0. Alternately you could disable springsettings changes under the developer tab http://zero-k.info/mediawiki/Zero-K:Developing#Modifying_the_game