search

ZeroK-RTS / Zero-K

Open source RTS game running on the Spring/Recoil engine
https://zero-k.info
GNU General Public License v2.0
691 stars 208 forks source link

unit groups and unit settings should be restored after loading a game #4175

Open deee167 opened 4 years ago

deee167 commented 4 years ago

unit groups and unit settings should be restored after loading a game. Right now unit groups for sure aren't being loaded from a save.

GoogleFrog commented 4 years ago

As far as I know lua can't do anything about this.

deee167 commented 4 years ago

As far as I know lua can't do anything about this.

There is no way to do this? Are you sure this was never working before?

GoogleFrog commented 4 years ago

That isn't what I said. Are you going to look into it?

deee167 commented 4 years ago

That isn't what I said. Are you going to look into it?

What are you talking about? I'm not a Zero-K developer. I'm a player. I don't code Zero-K. I'm reporting a bug to make the game better.

Thanks

Arch-Shaman commented 4 years ago

Everyone can look into bugs, even nondevelopers. While you may not code ZK, you can contribute by investigating bugs or looking into solutions.

As far as I know lua can't do anything about this.

Spring.SetUnitGroup (needs ModUICtrl)

( number unitID, number groupID ) -> nil

Combine this with Spring.GetGroupUnits() on save.

I can have a patch available later today for testing, @deee167. I would like you to test it.

deee167 commented 4 years ago

Everyone can look into bugs, even nondevelopers. While you may not code ZK, you can contribute by investigating bugs or looking into solutions.

As far as I know lua can't do anything about this.

Spring.SetUnitGroup (needs ModUICtrl)

( number unitID, number groupID ) -> nil

Combine this with Spring.GetGroupUnits() on save.

I am also contributing by reporting bugs and providing feedback. I am also discussing the issues with you guys and investigating the behaviours.

That would be great. Will it come through as a normal upgrade when starting Zero-K?

Arch-Shaman commented 4 years ago

Yes, if it works it gets stabled and everyone gets it. I'll add this to commshare too, since IIRC commsharing players don't carry over their unitgroups.

deee167 commented 4 years ago

I noticed another issue with save and load. Not sure if you want another ticket for it or not. The issue is some or all buildings don't have their collision loaded properly after a save and load. For eg. Building some Lucifer turrets, saving the game, then loading the game results in the following issue: When you are in build preview and trying to build more buildings, eg. more Lucifers, the game shows a green grid indicating that you can build the new building even when you are right overtop of the previously build Lucifers that you just loaded.

Arch-Shaman commented 4 years ago

Should open another ticket for that. Probably would be nice if @sprunk could kindly add a save/load tag too?

deee167 commented 4 years ago

Any luck?

deee167 commented 4 years ago

Did you make a change to the game? It might not be related, but I can't load any of my saves anymore, it crashes the game.

deee167 commented 3 years ago

save load is broken any update?