`gui_group_recall_fix.lua` is now redundant

[sprunk]

Here's a set of actions:

• put starting commander in group 1. he is the entire group
• select the commander by clicking him
• press 1 (or whatever the binding is) a single time. this should do nothing because a single-tap is selection. in particular it should not focus the commander (i.e. move camera to center of the group) despite the whole group already being selected
• wait 2s or so
• press 1 (or whatever the binding is) a single time. this should do nothing because a single-tap is selection. in particular it should not focus the commander despite the whole group already being selected and despite the previous action being selection and despite the previous keypress being 1

As far as I can tell the gui_group_recall_fix.lua widget is what implements this, and without the widget it would focus the group when pressing the button. If this is the case then the behaviour can be implemented via engine keybinds since selection and focus are now split and can be bound separately to single-tap and double-tap:

bind 1 group select 1
bind 1,1 group focus 1

[GoogleFrog]

How new is double tap binding? It's very slightly scary, do we need to do anything for it?

[sprunk]

• keychains (aka multi-tap bindings) are from 2022, so not completely fresh but still recent. Version 105-1300ish.
• we would either need to make epicmenu key handler know about them, or (for this particular case) to add special handling where binding "select group N" to key X also automatically creates a binding for "focus group N" to keychain X,X.
• i am unsure how the above (or keychains in general) handle modifier keys. AFAIK it's pretty robust but it would be best to stay safe and test.