ZeroNetJS / zeronet-js

ZeroNet in JS
MIT License
47 stars 9 forks source link

Feature: TLS #81

Closed mkg20001 closed 6 years ago

mkg20001 commented 6 years ago

Goals:

mkg20001 commented 6 years ago

Currently it just times out without sending anything screenshot

mkg20001 commented 6 years ago

Found the possible cause of the timeout: The net.socket is never connected. Seems like .pipe doesn't connect it.

mkg20001 commented 6 years ago

Now I'm getting Error: 139640545445696:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:../deps/openssl/openssl/ssl/s23_clnt.c:797:

danimesq commented 6 years ago

Reference: #54.

danimesq commented 6 years ago

Reference: https://github.com/ZeroNetJS/zeronet-js/issues/1.

codecov[bot] commented 6 years ago

Codecov Report

Merging #81 into master will decrease coverage by 1.48%. The diff coverage is 88.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   54.74%   53.26%   -1.49%     
==========================================
  Files          54       49       -5     
  Lines        2192     2007     -185     
==========================================
- Hits         1200     1069     -131     
+ Misses        992      938      -54
Impacted Files Coverage Δ
zeronet-client/lib/stream/bridge.js 93.82% <ø> (-0.84%) :arrow_down:
zeronet-crypto/gen.js 100% <100%> (ø)
zeronet-crypto/tls.js 87.09% <86.51%> (ø)
zeronet-client/lib/handshake.js 91.04% <0%> (-7.81%) :arrow_down:
zeronet-swarm/nat/index.js 5.66% <0%> (-0.48%) :arrow_down:
zeronet-protocol/lib/proto/handshake.js 93.84% <0%> (-0.19%) :arrow_down:
zeronet-node/lib/index.js 98.66% <0%> (-0.02%) :arrow_down:
zeronet-zite/lib/discovery/index.js 45.45% <0%> (ø) :arrow_up:
zeronet-client/lib/duplex.js 67.44% <0%> (ø) :arrow_up:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66e52f2...c0327a1. Read the comment docs.

mkg20001 commented 6 years ago

So far TLS works, but interop fails.

mkg20001 commented 6 years ago

Closing in favor of #88