ZeroNetX / ZeroNet

ZeroNetX - Decentralized websites using Bitcoin crypto and BitTorrent network
https://zeronet.dev
Other
215 stars 32 forks source link

Switch to Ed25519 for keys #110

Open zolagonano opened 2 years ago

zolagonano commented 2 years ago

I saw this issue on HelloZeroNet, I think it's better to switch to Ed25519 and also keep the compatibility with ECDSA for old zero sites.

https://github.com/HelloZeroNet/ZeroNet/issues/2784

canewsin commented 2 years ago

I will visit this soon, currently reviewing @geekless some changes to pull to into this repo.

canewsin commented 2 years ago

If you have time, you can submit a pr with modifications

canewsin commented 2 years ago

@zolagonano I see you have some rust repos on your github, I suggest you to use zeronet cryptography crate https://crates.io/crates/zeronet_cryptography implement changes using rust, this will in turn improve signing speed for both old and new key versions.

canewsin commented 2 years ago

I was planning to port ZeroNet to rust in future so suggested the above.

zolagonano commented 2 years ago

Unfortunately, I'm not familiar with ZeroNet's codebase yet

canewsin commented 2 years ago

@zolagonano You can look into zerunet repo incomplete rust implementation. will provide link

canewsin commented 2 years ago

https://github.com/canewsin/zerunet

zolagonano commented 2 years ago

@zolagonano You can look into zerunet repo incomplete rust implementation. will provide link

Okay, also i can turn crate zeronet_cryptography into a python module (using PyO3 or rust-cpython) that can be used inside this fork to speed up signing or key generation process.

canewsin commented 2 years ago

Okay, also i can turn crate zeronet_cryptography into a python module (using PyO3 or rust-cpython) that can be used inside this fork to speed up signing or key generation process.

This is what I suggested, implement sign logic there and make ffi bindings.

canewsin commented 2 years ago

@zolagonano Are you interested in rust version of ZeroNet, started working on it.

zolagonano commented 2 years ago

@zolagonano Are you interested in rust version of ZeroNet, started working on it.

Yeah, I am. But I don't know where to start.

canewsin commented 2 years ago

I will allow access to rust repo

canewsin commented 2 years ago

@zolagonano invitation sent.

zolagonano commented 2 years ago

@zolagonano invitation sent.

thanks