Multi User enabled by default

Merith-TK commented 2 years ago

Step 1: Please describe your environment

ZeroNet version: docker: canwsin/zeronet as of 2-21-2022
Operating system: Windows 11 Host, Docker Container using WSL2 (effectively linux) backend
Web browser: Brave
Tor status: always
Opened port: Unsure
Special configuration: Required Special Config to work around bug

Step 2: Describe the problem:

By default, the container run with multiuser plugin enabled,

this is my config for docker-compose

  zeronet:
    image: canewsin/zeronet:latest
    container_name: zeronet
    environment:
      - ENABLE_TOR=true
    restart: always
    ## For Some reason, modifying the command that is normally ran, causes
    ## issues with the container, so default to sh file that does the same
    ## thing as the command
    command: '/bin/sh /root/data/start.sh'
    ports:
      - 43110:43110
    volumes:
      - ./zeronet/:/root/data

this is start.sh

#!/bin/sh
if [ $ENABLE_TOR != "" ]; then
    tor&
fi

## This line is only required because of this bug, I have to remove the multiuser plugin directly to prevent it from loading
rm -rf /root/plugins/*Multiuser*

## zeronet.link because I have DNS and custom SSL Cert fekkery being performed on my system
python3 zeronet.py --ui_ip 0.0.0.0 --ui_host "zeronet.link" --fileserver_port 26117

I use a docker container with zeronet along with caddy, pi-hole dns, and an self signed SSL certificate to access zeronet from zeronet.link instead of the usual 127.0.0.1, just looks nicer also allows me to actually share the links

Steps to reproduce:

Use docker container

Observed Results:

Multiuser is enabled by default

Expected Results:

Multiuser to not be disabled

canewsin commented 2 years ago

@Merith-TK

Expected Results: Multiuser to not be disabled

You're expecting multiuser plugin to be disabled by default, right ?

Merith-TK commented 2 years ago

yes, that is what I am expecting from the docker container,

maybe use a environment variable to enable/disable the multiuser plugin —Merith

On Sun, Mar 6, 2022 at 8:39 PM canewsin @.***> wrote:

@Merith-TK https://github.com/Merith-TK

Expected Results: Multiuser to not be disabled

You're expecting multiuser plugin to be disabled by default, right ?

— Reply to this email directly, view it on GitHub https://github.com/ZeroNetX/ZeroNet/issues/152#issuecomment-1060188218, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPQOXWKJTEK7JSHMM7U67DU6WCB3ANCNFSM5PASW4WQ . You are receiving this because you were mentioned.Message ID: @.***>

marek22k commented 2 years ago

I had the same problem. I then disabled the plugin using docker exec -it zeronet sh.

Merith-TK commented 2 years ago

i used docker compose so i just deleted the plugin files

ZeroNetX / ZeroNet