search

ZeroNetX / zeronet_mobile

ZeroNet Mobile is an Native Client for Mobile Devices running Android.
GNU General Public License v3.0
77 stars 12 forks source link

Update Readme, add makefile instead of build.bat #2

Closed Merith-TK closed 2 years ago

Merith-TK commented 4 years ago

this PR is going to be in progress for a little bit as i am making tweaks, right now it doesn't really do anything except update the readme and use a makefile instead of a .bat file as the .bat file doesnt work because there is no release on GitHub for this app yet

the reason why i am removing buildapk.bat is because it just doesnt work with the git repo in its current state, as from what i can gather (never having used dart/flutter before) from utils.dart, that compile() checks github for a release and if none are found, error and tell the person to check their android/version.properties file 

dart buildtools\utils.dart compile
Unhandled exception:
Update version.properties
#0      compile (file:///C:/Users/merith/Documents/Workspace/zeronet_mobile/buildtools/utils.dart:46:5)
#1      main (file:///C:/Users/merith/Documents/Workspace/zeronet_mobile/buildtools/utils.dart:14:7)
#2      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
make: *** [Makefile:5: release] Error 255

the Makefile also makes building easier as you can choose to build a WIP apk, or a release apk. as i show in the makefile

I also want to change the icon but cant decide wether or not the icon needs to be changed from what i have I made the lines a bit thinner, and added a black background to the in the center

icon_varient-2 The PSD/KRA files for the image

canewsin commented 4 years ago

@Merith-TK Thanks for the PR. About Icon i feel better with current icon as proposed one is somewhat narrowed to me, the current icon is not just design made, the spaces refers to the different platforms supported by zeronet mobile client, currently android, in future i will extend it to pc and other platforms, supporting native apps.

About ReadMe.md, i left that readme intentionally because only fraction of users know about flutter build structure. Sure i will improve the Readme soon with build instructions and other necessary details.

buildapk.bat is pretty old, i will definitely improve that as well as Makefile suggested.

i will close this PR once all those proposed changes are made.

Merith-TK commented 4 years ago

@Merith-TK Thanks for the PR. About Icon i feel better with current icon as proposed one is somewhat narrowed to me, the current icon is not just design made, the spaces refers to the different platforms supported by zeronet mobile client, currently android, in future i will extend it to pc and other platforms, supporting native apps.

About ReadMe.md, i left that readme intentionally because only fraction of users know about flutter build structure. Sure i will improve the Readme soon with build instructions and other necessary details.

buildapk.bat is pretty old, i will definitely improve that as well as Makefile suggested.

i will close this PR once all those proposed changes are made.

As for the icon, i proposed this one mainly to suggest an alternative or better design scheme, i will be honest i was working with Krita so my tools were not as actuate in shape as i desired, but it still made a good icon

As for the playstore readme, shall i decrease its length and restore the original readme in such a way that it includes the playstores, so people who see this repo know what its about, but also contains the information to get then started?

The makefile i would like to keep as it is right now