search

ZeroNoRyouki / ExtremeReactors2

19 stars 17 forks source link

[Texture Pack Issues] infinite texture pack load/unload after opening a gui ; "TEXTFIELD_NORMAL_3D_BORDER_LIGHT" not behaving as expected #172

Open geradeaus007 opened 1 week ago

geradeaus007 commented 1 week ago

Details

MC: 1.20.1 Forge: 47.3.5 ER: 1.20.1-2.0.84 ZeroCore2: 1.20.1-2.1.45

Sterile environment (no other mods)

First issue

Description

When a "er_gui_theme.json" file, either modified or original, is included in a texture pack you will not be able to load or unload the texture pack once a extreme reactors gui has been opened once. Prepaired texture pack: Example.zip

Steps to reproduce

  1. Copy "er_gui_theme.json" into a texturepack
  2. Start minecraft and load into a world
  3. Open any gui from Extreme Reactors
  4. Try to load/unload the texture pack
  5. Witness infinite loading

    Additional info

    Before step 3 you can unload/load the texture pack fine. And after step 3 you can only unload/load the texture pack after a game restart.

Second issue

Description

When changing the value of "TEXTFIELD_NORMAL_3D_BORDER_LIGHT" in "er_gui_theme.json" not only the light part of the textfield boarder changes.

Steps to reproduce

  1. Load a texture pack with the value for "TEXTFIELD_NORMAL_3D_BORDER_LIGHT" changed
  2. Open the gui of any Redstone Port and change to a menu with a textfield (here: Core Heat)
  3. Witness the effects

    Additional info

    It tints the icons and buttons, as well as any text in the gui. When changing to 000000FF (black, opaqe): 2024-09-22_16 39 29

When making the color transparent 00000000 (black, transparent): 2024-09-22_16 40 41 Texture pack for this case: Example2.zip

Expected output when changing to red (to see the expected area): 2024-09-22_16 36 01 Expected from description in "GUI Theme file.md".

  • TEXTFIELD_NORMAL_3D_BORDER_LIGHT
    3D border of a text field, light sections.

    Other

    I don't know if this is an imprementation issue or a ZeroCore2 issue, since you are the same developer I will only post this here and not on both repositories.

ZeroNoRyouki commented 1 week ago

Regarding the first issue: do you have any log?

geradeaus007 commented 1 week ago

The relevant log parts (first line after loading/unloding texture pack to last one). Same environment as in original issue and unsing the Example.zip (no changes to "er_gui_theme.json").

Loading normally [12:02:48] [Render thread/INFO] [minecraft/FolderRepositorySource]: Found non-pack entry 'D:\Games\Prism\Instances\1.20.1\.minecraft\resourcepacks\ATD.zip.disabled', ignoring [12:02:48] [Render thread/INFO] [minecraft/FolderRepositorySource]: Found non-pack entry 'D:\Games\Prism\Instances\1.20.1\.minecraft\resourcepacks\Example2.zip.disabled', ignoring [12:02:49] [Render thread/INFO] [minecraft/FolderRepositorySource]: Found non-pack entry 'D:\Games\Prism\Instances\1.20.1\.minecraft\resourcepacks\ATD.zip.disabled', ignoring [12:02:49] [Render thread/INFO] [minecraft/FolderRepositorySource]: Found non-pack entry 'D:\Games\Prism\Instances\1.20.1\.minecraft\resourcepacks\Example2.zip.disabled', ignoring [12:02:49] [Render thread/INFO] [minecraft/ReloadableResourceManager]: Reloading ResourceManager: vanilla, mod_resources [12:02:49] [Worker-Main-7/INFO] [minecraft/UnihexProvider]: Found unifont_all_no_pua-15.0.06.hex, loading [12:02:49] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'bigreactors:blockstates/energizerstatus.json' missing model for variant: 'bigreactors:energizerstatus#' [12:02:49] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Unable to load model: 'bigreactors:energizerstatus#inventory' referenced from: bigreactors:energizerstatus#inventory: java.io.FileNotFoundException: bigreactors:models/item/energizerstatus.json [12:02:50] [Render thread/WARN] [minecraft/SoundEngine]: Missing sound for event: minecraft:item.goat_horn.play [12:02:50] [Render thread/WARN] [minecraft/SoundEngine]: Missing sound for event: minecraft:entity.goat.screaming.horn_break [12:02:50] [Render thread/INFO] [mojang/Library]: OpenAL initialized on device OpenAL Soft on Lautsprecher (Logitech G733 Gaming Headset) [12:02:50] [Render thread/INFO] [minecraft/SoundEngine]: Sound engine started [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 1024x1024x4 minecraft:textures/atlas/blocks.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 1024x1024x4 minecraft:textures/atlas/armor_trims.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas [12:02:50] [Render thread/WARN] [minecraft/ShaderInstance]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program. [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas [12:02:50] [Render thread/INFO] [minecraft/TextureAtlas]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas
Loading infinitly [12:04:10] [Render thread/INFO] [minecraft/FolderRepositorySource]: Found non-pack entry 'D:\Games\Prism\Instances\1.20.1\.minecraft\resourcepacks\ATD.zip.disabled', ignoring [12:04:10] [Render thread/INFO] [minecraft/FolderRepositorySource]: Found non-pack entry 'D:\Games\Prism\Instances\1.20.1\.minecraft\resourcepacks\Example2.zip.disabled', ignoring [12:04:11] [Render thread/INFO] [minecraft/FolderRepositorySource]: Found non-pack entry 'D:\Games\Prism\Instances\1.20.1\.minecraft\resourcepacks\ATD.zip.disabled', ignoring [12:04:11] [Render thread/INFO] [minecraft/FolderRepositorySource]: Found non-pack entry 'D:\Games\Prism\Instances\1.20.1\.minecraft\resourcepacks\Example2.zip.disabled', ignoring [12:04:11] [Render thread/INFO] [minecraft/ReloadableResourceManager]: Reloading ResourceManager: vanilla, mod_resources, file/Example.zip [12:04:11] [Worker-Main-9/INFO] [minecraft/UnihexProvider]: Found unifont_all_no_pua-15.0.06.hex, loading [12:04:12] [Worker-Main-12/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'bigreactors:blockstates/energizerstatus.json' missing model for variant: 'bigreactors:energizerstatus#' [12:04:12] [Worker-Main-12/WARN] [minecraft/ModelBakery]: Unable to load model: 'bigreactors:energizerstatus#inventory' referenced from: bigreactors:energizerstatus#inventory: java.io.FileNotFoundException: bigreactors:models/item/energizerstatus.json