ZeroNoRyouki / ExtremeReactors2

19 stars 17 forks source link

The Extrem Book has some Issues #40

Closed jajajafeti closed 1 year ago

jajajafeti commented 3 years ago

Hello, I just downloaded ExtremeReactors2-1.16.4-2.0.23 and got Patchouli-1.16.4-50 installed. Now the recipies and basicaly the Items when u hover over them in the book, wont show anything or sometimes the wrong thing.

In this example it shows the recipie from the bottom image anotherone image

Maybe u want to look 4 ur selfe trough the book. I cant see how this is an issue on the user side. Let me know if u need morte info.

KuwuroUsagi commented 2 years ago

Many of the recipes shown in the book indeed do not match names/images, also some do not have names when hovered at all

Twisted-Code commented 1 year ago

I'm also experiencing this issue on Minecraft 1.18.2. Here I am pointing at the output on the top left but this recipe is supposed to be below the "control rod" title-text image

versions

(based on the mod menu, though the mod file names seems to corroborate): ExtremeReactors2: 1.18.2-2.0.51 Patchouli: 1.18.2-71.1 forge: 40.1.84

ZeroNoRyouki commented 1 year ago

Recipes and icons are OK, it's the displayed toolip that's wrong (it use the the one from the bottom recipe). Unfortunately this is a problem in Patchouli itself, because it does not take in consideration that one of its recipe page can be used in a double template like I'm doing in the ER book. I've had to put code in to actually stop Patchouli drawing both recipes on top of each other but I can't do the same for the tooltip

Twisted-Code commented 1 year ago

If I were you I would take a look at PneumaticCraft Repressurized's code for this. They also have pages containing multiple recipes, but the tooltips rendered correctly. image

ZeroNoRyouki commented 1 year ago

Yeah, they are using the default crafting page which pose a bit of a problem for me:

image

ZeroNoRyouki commented 1 year ago

Found a way around both problems:

image

Twisted-Code commented 1 year ago

ah, I see what you mean. You had to shorten the block names... maybe that should tell you something about your block names LOL? like couldn't you call it Reactor FE Tap? anyway, glad it's straightened out. So wait, what did you end up doing?

ZeroNoRyouki commented 1 year ago

Nah, I didn't changes the block names. I reworked how the crafting page of Patchouli handle the titles so that I could use custom ones instead of the block names.

Twisted-Code commented 1 year ago

That's what I mean. You needed to customize the page so that you could use titles that aren't ungodly long like... Well, your block names which have ungodly long names. (Sure, Reactor Passive Forge Energy Power Tap is descriptive, but did it ever occur to you you might be better off merging all of these blocks into one block somehow, since they all have a single responsibility "get energy out of the machine"? Of course, I'm making the assumption that's actually possible in this instance, but I feel like there must be some sort of way to leverage Java's polymorphism faculties here)

ZeroNoRyouki commented 1 year ago

They are split by design. A Reactor support only one output power system (if you want two different energy types you need two reactors) as I don't want you guys to build a fit-for-all reactor.

The passive / active split is to avoid having a GUI for setting that operation mode, as it will be more difficult for the player to troubleshoot: now you see directly that you are connecting a passive cable to a passive port.

That's why there are N power taps blocks.

Z

PS: they are already implemented by a single class plus one per the power system adapter