Translation keys are incorrect on 1.19 (with Forge's new Fluid API) - Githubissues

ZeroNoRyouki / ExtremeReactors2

19 stars 17 forks source link

Translation keys are incorrect on 1.19 (with Forge's new Fluid API) #88

Closed MaxNeedsSnacks closed 2 years ago

MaxNeedsSnacks commented 2 years ago

Starting in 41.0.28, Forge has changed the default display name of fluids to use the fluid_type.[namespace].[path] translatable component, rather than the previous fluid.[namespace].[path]

This means that ER fluids currently display incorrectly in recipe viewers such as REI which use that FluidType attribute directly, as seen in this screenshot:

I'm assuming this is just due to your localisation being a bit outdated here?

https://github.com/ZeroNoRyouki/ExtremeReactors2/blob/33f63a6073c1dedf5ddd02941de2f08e90a1c0b1/src/main/resources/assets/bigreactors/lang/en_us.json#L58-L68

ZeroNoRyouki commented 2 years ago

Fixed in 2.0.48 Thank you for the report Z