search

ZeroNoRyouki / ExtremeReactors2

19 stars 17 forks source link

[Bug] FTB Industrial Contraptions blocks missing as Moderator Pt2 #92

Closed TheonlyTazz closed 2 years ago

TheonlyTazz commented 2 years ago

Modpack Direwolf20 1.18

Modpack version 1.5.1

Mod version: ExtremeReactors2-1.18-2.0.45

All FTBIC Storage Blocks, with exception of Enderium are still not able to being used as Moderator blocks

Note, this is a follow up of a previous issue https://github.com/ZeroNoRyouki/ExtremeReactors2/issues/84

and issues on the FTB-Modpack Github https://github.com/FTBTeam/FTB-Modpack-Issues/issues/991

ZeroNoRyouki commented 2 years ago

They need to add their blocks to the correct forge:storage_block/ tag

TheonlyTazz commented 2 years ago

They need to add their blocks to the correct forge:storage_block/ tag

we have the blocks tagged, that was one of the first things i checked image

ZeroNoRyouki commented 2 years ago

You tagged the items but not the blocks.

Moderators are in-world blocks so the block tags are checked. The tooltip is displayed on items but that's me doing it so player can see it in inventories.

PS: this applies to turbine coils too just in case

PS2: since we are here, is zapps something to be used by external mods too? I've looked at it and it doesn't look designed with that in mind

MaxNeedsSnacks commented 2 years ago

FTBIC as a whole originally was designed for FTB Ultimate — Anniversary Edition by Lat, and Lat is... notoriously not terribly good at designing systems with other mods adding onto them in mind, so the entire energy system might be a little janky :P Whatever you may need tho, I should hopefully be able to change about Zaps

ZeroNoRyouki commented 2 years ago

Ah The thing that baffled me the most is that you don't really have an energy network and all the consumers/producers need to keep track of the connectted devices themselves.

You get away with it because, at a first glance, all your consumers and producers block entities derive from the same base class that keep track of that but an external mod will need to reinplement that internally (being unable to use your base BE class) and that will be not that great to do since we would need to keep track of your internal implementation. Your energy handler is internal details too technically speaking