ZeroNoRyouki / ExtremeReactors2

19 stars 17 forks source link

Separate Texture Assets for GUI Buttons [Suggestion] #97

Closed CyanideX closed 1 year ago

CyanideX commented 2 years ago

Would it be possible to get texture assets for the GUI buttons instead of them being hard coded? I would love to add mod support for my Unity and Unity Dark packs but it's not possible at the moment.

image

ZeroNoRyouki commented 2 years ago

The problem with doing that is that all the controls in my GUI framework are designed to be rendered (and used) with arbitrary sizes (fixed, suggested, computed from their parent control layout and content or their own content, etc) and being able to keep doing so with textures would require dropping "effects" like the 3D shadow or the "hover" highlighting and having something like 9 textures per button state

CyanideX commented 2 years ago

I understand completely; it's efficient! Unfortunately, it makes it very difficult for resource packs to offer support for mods when buttons are hardcoded. 😅 Is there any possibility of putting some color config options somewhere that I could access, preferably with a gradient toggle?

ZeroNoRyouki commented 2 years ago

I think that it's possibile, I just need to find an elegant way to do implement it so that this could be used by other mods too. I'll take a look this weekend

ZeroNoRyouki commented 2 years ago

Would you be able to replace a json file from my assets with one with your colours?

ZeroNoRyouki commented 1 year ago

Where you able to check out?

CyanideX commented 1 year ago

Sorry, it's been a very busy past few months for me. I completely forgot to reply.

Would you be able to replace a json file from my assets with one with your colours?

Yes, that would work as long as I could remove the gradient. 🙂 Is there a new build for me to test that with?

ZeroNoRyouki commented 1 year ago

-- link removed --

Here you go. The build is for 1.16.5

The file you need to override is er_gui_theme.json, in main resources folder of ER (bigreactors:er_gui_theme.json). There is also a .md file with a description of the content of the json file,

You will be able to modify every colour used by all the GUI screens and controls in ER.

ZeroNoRyouki commented 1 year ago

I've just pushed out ZeroCore 2.1.28 and ER 2.0.57 for 1.16.5. They contains an updated version of what I've sent you before (along with a couple of fixes in some drawing primitives). I've tested them with a resource pack and all works fine