ZeroPhone / ZPUI

Official ZeroPhone UI framework, based on pyLCI
http://zpui.rtfd.org/
Apache License 2.0
79 stars 19 forks source link

Some UI elements don't exit on LEFT where it's expected #108

Closed CRImier closed 5 years ago

CRImier commented 5 years ago

We have an informal UX guideline - UI elements need to exit on LEFT wherever possible. Some UI elements don't, however:

derivmug commented 5 years ago

I have made some a small change to TextReader which makes it exit on LEFT when it's in the leftmost position. The changes are in the derivmug-matrix branch

CRImier commented 5 years ago

Thank you! Now, all that's left is the Numpad*Elements =)

derivmug commented 5 years ago

NumpadCharInput calls the following method on LEFT, so I believe this might be already implemented.

`

def deactivate_if_first(self):

""" Deactivates the UI element if it hasn't yet had a character entered """

if self.position == 0:

    self.deactivate()

`

CRImier commented 5 years ago

ohh. why wouldn't it work then? let me see

CRImier commented 5 years ago

Okay. Tested, and understood why it didn't work for me - this is fixed, thank you @derivmug =)