ZeroPhone / ZPUI

Official ZeroPhone UI framework, based on pyLCI
http://zpui.rtfd.org/
Apache License 2.0
79 stars 19 forks source link

DatePicker, TimePicker + calendar app #115

Closed CRImier closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #115 into devel will increase coverage by 0.89%. The diff coverage is 69.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #115      +/-   ##
==========================================
+ Coverage   28.19%   29.08%   +0.89%     
==========================================
  Files         209      214       +5     
  Lines       16375    16731     +356     
==========================================
+ Hits         4617     4867     +250     
- Misses      11758    11864     +106
Impacted Files Coverage Δ
ui/__init__.py 100% <100%> (ø) :arrow_up:
ui/time_picker.py 56.94% <56.94%> (ø)
ui/date_picker.py 66.42% <66.42%> (ø)
apps/calendar/main.py 71.42% <71.42%> (ø)
ui/tests/test_time_picker.py 74.07% <74.07%> (ø)
ui/tests/test_date_picker.py 83.33% <83.33%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b352410...9d0d0a5. Read the comment docs.

CRImier commented 5 years ago

@derivmug I decided to improve navigation: if you're on Monday and press LEFT, it should go to previous Sunday - same for reverse. I added it, had to change the code internally a little bit - also, did some changes for better maintainability.

TODO:

Also, you changed the calendar app to use TimePicker, I suggest you just create a new app in apps/example_apps next time. Changed it back in the meantime.

CRImier commented 5 years ago

Merging this for now, #101 has some more TODOs.