LouisPi commented 5 years ago

Hey here are my changes. Thumbnail sticks to aspect ratio by downsizing the image and then borders are added by extra code. Please test this on other size screens (128x64 mainly). Also, this fixes some minor errors on st7735.py

codecov[bot] commented 5 years ago

Codecov Report

Merging #133 into devel will decrease coverage by 0.09%. The diff coverage is 4.76%.

@@            Coverage Diff            @@
##            devel     #133     +/-   ##
=========================================
- Coverage   37.63%   37.54%   -0.1%     
=========================================
  Files         231      232      +1     
  Lines       18024    18055     +31     
=========================================
- Hits         6784     6778      -6     
- Misses      11240    11277     +37

Impacted Files	Coverage Δ
output/drivers/st7735.py	`0% <0%> (ø)`
splash.py	`9.09% <5.55%> (-24.25%)`	:arrow_down:
ui/date_picker.py	`65.03% <0%> (-2.8%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abf93d6...b2a549c. Read the comment docs.

CRImier commented 5 years ago

I'm merging this despite the warning - splash screen exceptions don't cause ZPUI launch process to fail (on purpose), so I'll merge first and then test, as there's hardly any potential for failure

LouisPi commented 5 years ago

Will try add the smaller screen for text stuff today

ZeroPhone / ZPUI

bug fixes and improved splash.py. TEST ON OTHER SCREENS FIRST PLEASE #133

Codecov Report