Replace Printer's boolean flags with threading.Event - Githubissues

ZeroPhone / ZPUI

Official ZeroPhone UI framework, based on pyLCI

http://zpui.rtfd.org/

Apache License 2.0

78 stars 19 forks source link

Replace Printer's boolean flags with threading.Event #146

Open CRImier opened 5 years ago

CRImier commented 5 years ago

https://github.com/ZeroPhone/ZPUI/blob/6a74d748e2fcecc1229645d8de8e15d0e67c54ea/ui/printer.py#L22

This solution is old. Now I see that:

Any simultaneously running Printers will probably interfere
It's not thread-safe - so, we might miss the changes when the CPU load is too high (as it used to happen with Refreshers and other UI elements).

We can use threading.Event instead, just like we do in BaseUIElements.