Recently, we've stumbled upon a problem - setters don't work properly in old-style classes (if at all). BaseListUIElement (the Backgroundable version, at least) uses setters to ensure proper variable passing between threads (specifically, masking a threading.Event() in the in_foreground property setter). If we have functionality in code that actually doesn't work because of such an obscure problem, that should be fixed.
Tasks:
[x] refactor UI elements to inherit from object
[x] test that is_foreground property still works as advertised and interacts with the underlying threading.Event object - adding tests would be stellar
[x] see if there are any more setters in ZPUI that currently might not work
[x] see if anything else is/was affected by the fact that currently classes don't inerit from object
CRImier
commented
6 years ago
Recently, we've stumbled upon a problem - setters don't work properly in old-style classes (if at all). BaseListUIElement (the Backgroundable version, at least) uses setters to ensure proper variable passing between threads (specifically, masking a
threading.Event()in thein_foregroundproperty setter). If we have functionality in code that actually doesn't work because of such an obscure problem, that should be fixed.Tasks:
objectis_foregroundproperty still works as advertised and interacts with the underlyingthreading.Eventobject - adding tests would be stellarobject