ZeroPhone / ZPUI

Official ZeroPhone UI framework, based on pyLCI
http://zpui.rtfd.org/
Apache License 2.0
79 stars 19 forks source link

Devel + snake game #95

Closed Gnu-Bricoleur closed 6 years ago

Gnu-Bricoleur commented 6 years ago

First commit for the snake game, the game is working but there's no score or menu yet

Gnu-Bricoleur commented 6 years ago

I think I've correct all the problems you saw except the one about the class base application, let me know if anything is amiss

CRImier commented 6 years ago

You seem to have accidentally committed the emulator flag file, if you could remove it, that'd be great! I will go test the game now =)

Gnu-Bricoleur commented 6 years ago

I hadn't notice that, shouldn't it be specified in the gitignore ?

CRImier commented 6 years ago

It should - will fix that, thank you =)

CRImier commented 6 years ago

So, it works, and it works well! I do have a list of improvements that we could make - would you be interested in making them yourself, or would you prefer leaving that to me?

Gnu-Bricoleur commented 6 years ago

I can try, I already have some ideas :

CRImier commented 6 years ago

Yay! I've refactored the code a little bit in the meantime, would you be interested in my changes?

Gnu-Bricoleur commented 6 years ago

Of course !

CRImier commented 6 years ago

Okay, let me try and pack them into separate commits (BTW, git add --patch is a great thing)

CRImier commented 6 years ago

Done! Pull the devel branch in now, I have added my changes, sorted by purpose in separate commits.

Gnu-Bricoleur commented 6 years ago

Thanks, I've seen your commits, i'll try to follow your guideline in further commits.