ZeroQI / Absolute-Series-Scanner

Seasons, absolute mode, Subfolders...
1.01k stars 155 forks source link

Trailer recognized as regular episode #330

Closed krbrs closed 3 years ago

krbrs commented 3 years ago

Platform

Operating system and version: Windows 10 current version Plex version: 1.21.4.4054

Expected Behavior

Scanner should distinguish between regular episode and trailer

Current Behavior

Trailer is recognized as regular episode

Steps to Reproduce

  1. Add folder to library and scan for new files
  2. See trailer matched as regular episode

image

Additional information

I put the anidb-id in the folder name because of trouble with recognitions in some cases

Logfiles:

Memories Off #5 Togireta Film [anidb-4139].filelist.log Memories Off #5 Togireta Film [anidb-4139].scanner.log

ZeroQI commented 3 years ago

https://github.com/ZeroQI/Absolute-Series-Scanner/blob/master/Scanners/Series/Absolute%20Series%20Scanner.py ANIDB-RX3 is the regex used so the 4th item in the list line 82 cic(r'(^|(?P<show>.*?)[ _\.\-]+)(TRAILER|PROMO|PV|T)[ _\.]?(?P<ep>\d{1,2})[ _\.]?(V\d)?([ _\.\-]+(?P<title>.*))?$')

Look like line 1045 i messed up, replace with the below and test if rx in ANIDB_RX[:-2]: ### AniDB Specials ################################################################

ZeroQI commented 3 years ago

https://github.com/ZeroQI/Absolute-Series-Scanner/issues/328 i fixed supposedly the other bug but broke this. reverting [https://github.com/ZeroQI/Absolute-Series-Scanner/commit/6cf53c9561f8c50b923aad37652ed3a7251ed558] solves this one, but need to solve bug 328 again

krbrs commented 3 years ago

Look like line 1045 i messed up, replace with the below and test if rx in ANIDB_RX[:-2]: ### AniDB Specials ################################################################

This line replaced fixes #330 but breaks #328 as you said. Logfiles below for both in a new Test-Library:

Idolmaster Cinderella Girls Gekijou (2017) [anidb-13274].filelist.log Idolmaster Cinderella Girls Gekijou (2017) [anidb-13274].scanner.log

Memories Off #5 Togireta Film [anidb-4139].filelist.log Memories Off #5 Togireta Film [anidb-4139].scanner.log

ZeroQI commented 3 years ago

Reverted code, closing that one, need to really fix #329 now