ZeroQI / Absolute-Series-Scanner

Seasons, absolute mode, Subfolders...
1k stars 155 forks source link

Add season poster urls for tvdb4 online setup #40

Closed EndOfLine369 closed 8 years ago

EndOfLine369 commented 8 years ago

Carried over from discussion from https://github.com/ZeroQI/Absolute-Series-Scanner/pull/36

@EndOfLine369 Hmmmm....On further thought, maybe we don't want to store these images at all. I could see people complain about image rights. We could just store the URLs to the images. And still need a way for HAMA to know when the xml is used for seasons.

As xml, we can easily just add in a separate entry to not interfere with the other entries as we are searching for anime tags "/tvdb4entries/anime[@tvdbid='%s']" in ASS. EX:

  <anime tvdbid="88031" name="Dragon Ball Kai">
    01|001|016|Saiyan Saga
    02|017|054|Frieza Saga
    03|055|067|Androids Saga
    04|068|098|Cell Saga
    05|099|133|Majin Buu Saga
    06|134|159|Evil Buu Saga
  </anime>
  <posters tvdbid="88031" name="Dragon Ball Kai">
    01|[URL]
    02|[URL]
    03|[URL]
    04|[URL]
    05|[URL]
    06|[URL]
  </posters>

Would not recommend separating into separate files and that could be an issue when reconciling file entries.

@sven-7 I think the URL solution is a good compromise from a storage/rights perspective. Could we design it either way so there can be more than one per season? For example:

 <anime tvdbid="88031" name="Dragon Ball Kai">
    01|001|016|Saiyan Saga
    02|017|054|Frieza Saga
    03|055|067|Androids Saga
    04|068|098|Cell Saga
    05|099|133|Majin Buu Saga
    06|134|159|Evil Buu Saga
  </anime>
  <posters tvdbid="88031" name="Dragon Ball Kai">
    01|[URL]
    01|[URL]
  </posters>

@EndOfLine369 I don't see an issue with that to allow people different pictures available. But would probably need to make a rule for the file of only X images max per season. 2 per season?

@sven-7 Seems fair to me.

@ZeroQI

<anime tvdbid="88031" name="Dragon Ball Kai">
    01|001|016|[URL]|Saiyan Saga
    02|017|054|[URL]|Frieza Saga
    03|055|067|[URL]|Androids Saga
    04|068|098|[URL]|Cell Saga
    05|099|133|[URL]|Majin Buu Saga
    06|134|159|[URL]|Evil Buu Saga
  </anime>

I thought you did the posters yourself... If thetvdb have them yes a link will be great

Would not recommend separating into separate files and that could be an issue when reconciling file entries.

@EndOfLine369 "Would not recommend separating into separate files and that could be an issue when reconciling file entries." I had already mentioned that or are you meaning separate entries in the file?

If we combined the 'anime' & 'poster' tags, we could not have more than one poster available for a season. I would prefer not all to be in one entry as the url will make the line exceedingly long and would think is best to keep the 'anime' entry same as the local 'tvdb4.mapping' file's content.

@ZeroQI The poster is done by the agent so technically no need for a single file having both but it's simpler...

We could have a variable number of arguments, the format stays compatible and allows local file to specify poster link too...

<anime tvdbid="88031" name="Dragon Ball Kai">
    01|001|016|Saiyan Saga|[URL]|[URL]
    02|017|054|Frieza Saga|[URL]|[URL]|[URL]
    03|055|067|Androids Saga|[URL]
    04|068|098|Cell Saga|[URL]|[URL]
    05|099|133|Majin Buu Saga|[URL]|[URL]|[URL]
    06|134|159|Evil Buu Saga|[URL]|[URL]
  </anime>

The tvdb id would be unique so i don't think there will be issues reconciliating entries, like what we do with the xml mapping file from scudlee's... single file easier to maintain...

tvdb4.posters.xml
 <posters tvdbid="88031" name="Dragon Ball Kai">
    01|[URL]
    01|[URL]
    02|[URL]
    02|[URL]
    03|[URL]
    04|[URL]
    05|[URL]
    06|[URL]
  </posters>

Opinions?