ZeroQI / Absolute-Series-Scanner

Seasons, absolute mode, Subfolders...
999 stars 155 forks source link

.hack series problem with mapping #487

Open koalix opened 6 months ago

koalix commented 6 months ago

Operating system and version: Windows 10 / Ubuntu 22.04 (both fully patched) Plex version: 1.40.1.8120

Expected Behavior

.hack seasons LIMINALITY, DUSK and ROOTS are mapped wrong

Current Behavior

The proper behaviour would be LIMINALITY to be mapped to Special, episodes 02 to 05, DUSK mapped as season 02 and ROOTS as season 03.

Currently, LIMINALITY is mapped as season 02, ROOTS and DUSK as season 03.

Logs for the scanner job: hack ROOTS.scanner.log hack DUSK.scanner.log hack LIMINALITY.scanner.log

Additional information

I don't have the files to test if .hack//Sekai no Mukou ni (a8606) is mapped right.

ZeroQI commented 3 months ago

Anidb4 mode, this is a tricky one, i didn't code it but it is located lines 910 to 993 https://github.com/ZeroQI/Absolute-Series-Scanner/commit/8a2f17e https://github.com/ZeroQI/Absolute-Series-Scanner/blob/master/Scanners/Series/Absolute%20Series%20Scanner.py#L910

The season_map seem correct '222': {'max': 0, 'min': 0}, #liminality '5459': {'max': 0, 'min': 0}, '5391': {'max': 0, 'min': 0}, '8606': {'max': 0, 'min': 0}, '1135': {'max': 0, 'min': 0}, '7883': {'max': 0, 'min': 0}, '24': {'max': 1, 'min': 1}, #.hack//sign '447': {'max': 2, 'min': 2}, #.hack//dust / legend of the swighlight / Tasogare no Udewa Densetsu '4324': {'max': 3, 'min': 3}, #.hack//roots

LIMINALITY is mapped as season 02, ROOTS and DUSK as season 03, that seem like it should be different seasons Koalix expectation:

Relationship graph: https://anidb.net/anime/222/relation/graph

@EndOfLine369 Is Koalix right in his expectations? Should 222 liminality be season 2, 447 dust be season 3, 4324 roots be season 4, or is the relationship so messed up it is not reconciliable algorythmicaly ?