ZeroQI
commented
7 years ago Due to complication in separating the anidb and tvdb code in their respective module files, by the need to manage the failover of one meta source to the other in the absence of content, i have the regret to announce that i will have to download each meta source in a meta structure copied on plex metadata one.
Since that will be done i will devise a way to both give a choice per meta to pick the source and if none specified will not update that setting, and only update if different so all meta will be shown consistently in the same part of the log as well. That should free possibly some of the prefs variables.
For memory performance and code lisibility i have choosen namedTuples with default value not to have to specify every field name
@Dingmatt you have reached the 'Great Seer Level'. Wipe that grin of you face now :D To further the discussion I haven't tested yet but here is the gist. Please tell me you honest opinion but if positive you can yank the compliments :) Trying to sort the rest of the magic function then test if works. DingBatt, do you think it's inspired?
Having the below accurate would spare me buckets of time but don't have the courage right now: https://github.com/ZeroQI/Hama.bundle/wiki/Plex-Metadata-Fields-Available
init.py
MetaSources = {'AniDB': AniDB_meta, 'MyAnimeList': MyAnimeList_meta, 'FanartTV': FanartTV_meta, 'OMDb': OMDb_meta,
'TheTVDB': TheTVDB_meta, 'TheMovieDB': TheMovieDB_meta, 'Plex': Plex_meta # all meta sources in a dict of namedTuples
}
Plex.UpdateMeta(MetaSources, movie)common.py
from collections import namedtuple, Mapping
Movie = namedTupleDefaults('source', 'title summary originally_available_at rating absolute_index year content_rating_age trivia quotes original_title tagline art posters themes')
Serie = namedTupleDefaults('source', 'title summary originally_available_at rating studio countries duration genres tags collections art posters banners themes content_rating')
Season = namedTupleDefaults('number', 'summary posters banners')
Episode = namedTupleDefaults('number', 'title summary originally_available_at rating absolute_index thumbs writers directors producers')
def namedTupleDefaults(typename, field_names, default_values=()):
T = collections.namedtuple(typename, field_names)
T.__new__.__defaults__ = (None,) * len(T._fields)
T.__new__.__defaults__ = tuple( T(**default_values) if isinstance(default_values, collections.Mapping) else T(*default_values) )
return TPlex.py
from operator import attrgetter
MoviePriority = Movie ( title = (),
original_title = (),
summary = (),
rating = (),
originally_available_at = (),
art = (),
posters = (),
themes = (),
genres = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
tags = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
collections = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
year = (),
content_rating = (),
trivia = (),
quotes = (),
tagline = ('TheMovieDB')
)
SeriePriority = Serie ( title = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
summary = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
rating = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
originally_available_at = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
art = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV'),
posters = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
themes = ('Plex'),
banners = ('TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV'),
content_rating = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
studio = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
duration = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
genres = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
tags = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
collections = ('AniDB', 'TheTVDB', 'MyAnimeList' 'TheMovieDB', 'FanartTV', 'OMDb'),
countries = (),
#season = ()
)
Season_Priority = Season ( summary = ('TheTVDB'),
#episode = ('TheTVDB'),
poster = ('TheTVDB'),
banner = ()
)
Episode_Priority = Episode( number = "priority",
absolute_index = (),
title = ('AniDB', 'TheTVDB'),
summary = ('TheTVDB'),
originally_available_at = (),
rating = (),
writers = (),
directors = (),
producers = ()
)
def UpdateMeta(metadata, MetaSources, MetaSourceSeasons={}, MetaSourceEpisodes={})
for metadata_field in SeriePriority._fields: # Loop through namedTuple() "SeriePriority" (metadata) field names ("title", "summary", ...)
for metadata_source in getattr(SeriePriority, metadata_field): # Loop through the metadata source (ordered immutable) tuple ("AniDB", "TheTVDB", ...)
if metadata_source in MetaSources and hasattr(MetaSources[metadata_source], metadata_field):
selected_metadata_value = getattr( MetaSources[metadata_source], metadata_field)
if selected_metadata_value:
original_metadata_value = getattr( metadata , metadata_field)
if selected_metadata_value == original_metadata_value: Log.Info("Metadata field: '%s', Value: '%s'*" % (metadata_field, selected_metadata_value))
else:
Log.Info("Metadata field: '%s', Value: '%s', type: '%s', metadata.%s: '%s' " % (metadata_field, str(selected_metadata_value), type(selected_metadata_value), metadata_field, str(original_metadata_value)))
if isinstance(selected_metadata_value, string): setattr(metadata, metadata_field, selected_metadata_value)
elif metadata_field in ('genres', 'collections', 'tags', 'roles'): # selected_metadata_value is a tuple or list, can we copy whole list/tuple in one go???
original_metadata_value.clear()
for item in selected_metadata_value: # list of string or for 'roles' a list or tuple of tuples (('name', 'character', 'actor photo url'),...)
if metadata_field == 'roles':
role = original_metadata_value.new()
role.name, role.role, role.photo = item # tuple ('name', 'character', 'actor photo url')
else: original_metadata_value.add(item.strip())
elif metadata_field in ('seasons', 'episodes'):
for item in selected_metadata_value: UpdateMeta(original_metadata_value[item], MetaSourceSeasons, MetaSourceEpisodes)
return #no need for now, keeping in comment in case: f = operator.attrgetter("b.c", "b.d") #c, d = f(a)
break # No more metadata_source to try for that metadata_field
else: continue
else: Log.Info("Mispelt metadata source: '%s' in metadata field: '%s'" % (metadata_source, metadata_field))
# Enf of for metadata_source in getattr(SeriePriority, metadata_field):
# End of for metadata_field in SeriePriority._fields:any attribute starting with _ or __ gives an error... Might have to use a dict instead
Dingmatt
KingJ
sven-7
Currently, depending on if a series has been matched in standard mode or multi-episode mode (i.e. tvdb2/3/4 mode), different sources of metadata will be used for each episode's Director and Writer. In standard mode, it will be sourced from AniDB and in multi-episode mode it will be sourced from the TVDB.
We should be consistent in which source is used. Each site has a different approach for storing the metadata - AniDB stores it per-show and TVDB stores it per-episode. If AniDB is used as the metadata source, this means that if a show has different Directors or Writers for certain episodes, all episodes will have all potential Directors and Writers listed - when really only the Director or Writer who did that episode should be added.
As TVDB separates the data down to a per-episode level, i'd prefer to update the standard mode code to source the Director/Writer metadata from TVDB instead of AniDB as is currently done.
Any thoughts on the 'right' approach here?