Closed DJScias closed 6 years ago
It crashes so it's expected. I tried with my current unpublished beta code in progress and the error is gone but poster don't refreshes but am not finished coding the multi anidb xml support. that's a major change and am probably passed half of the completion, and i can't stop mid way through I will update this thread as soon as i make progress
Thank you for the response!
I'll be patiently awaiting information.
Regards.
Please test and check episode mappings are as they should, report ANY errors as i change little code but changed completely how it use to behave so could have missed something...
Hello there,
I've had to refresh the metadata twice and everything seemed in order after that. First time it had the TVDB episode information and naming but no poster.
Below is a (spoilered, due to size) log of my two metadata refreshes in Ao no Exorcist.agent-update.log
.
I'm not sure if this issue was applicable with Sword Art Online as well, since that's only still getting me Season 1 but Season 2 is just.. "Episode 1, Episode 2, etc..". vs
However I'm going to guess this is scanner-related and I probably have to try to apply the anidb2 fix, which unfortunately up to now hasn't really worked for me.
Is there anything else you need aside from the above from Ao no Exorcist or will that be all?
Regards.
TheTVDB.GetMetadata() - TVDBid: '248035', IMDbid: ''
common.LoadFile() - CacheTime: 'Thu Mar 29 06:25:25 2018', Limit: 'Fri Apr 6 22:43:31 2018', url: 'http://thetvdb.plexapp.com/api/A27AD9BE0DA63333/series/248035/all/en.xml', Filename: 'TheTVDB\xml\248035.xml' loaded from cache
TheTVDB.GetMetadata() - TVDBid: '248035', IMDbid: tt1799631, url: 'http://thetvdb.com/api/A27AD9BE0DA63333/series/248035/all/en.xml'
TheTVDB.GetMetadata(): abs_manual_placement_info: []
TheTVDB.GetMetadata() - TVDB - Episodes without Summary: []
TheTVDB.GetMetadata() - TVDB - Episodes missing: []
common.LoadFile() - CacheTime: 'Thu Mar 29 06:25:31 2018', Limit: 'Mon Apr 30 22:43:31 2018', url: 'http://thetvdb.com/api/A27AD9BE0DA63333/series/248035/banners.xml', Filename: 'TheTVDB\xml\banners\248035.banners.xml' loaded from cache
TheTVDB.GetMetadata() - anidb_offset: 0, AniDBid: 8148, anidb_array: []
1: TheTVDB.GetImages() - Posters : 0/15, Season posters: 0/6, Art: 0/13
2: TheTVDB.GetImages() - Posters : 15/15, Season posters: 6/6, Art: 13/13
Ok so i looked and the logs indeed show it download the second time around and are showing a difference which i didn't expect: count_valid['poster/season/fanart']=0 for some reason the first time only...
I need logs for season 2 of sword art online
In what way do you want me to have the folder structure for SAO before I try again and get you the logs?
Like this (without any [ani...] in the title)
Or do I need to use one of the anidb2
tricks? Like uh.. This:
Regards.
Because you have multiple seasons, it will associate a tvdbid and it should load just naturally i have reproduced that naming and had a crash for that series in AniDB.py or any series with ep mapping which was a far reaching Bug. Have it working now, please update to the latest agent released now and let me know. TheTVDB poster not loading the first run bug is gonna be present BUT i will need the TVDB log part like i pasted above and it will have additional logging to narrow it down.
When refreshing the metadata in situation 1:
It didn't do anything and still kept Season 2 as "Episode 1, Episode 2". Season 1 is still fine.
Sword Art Online.agent-update.log
did show something interesting though:
=== Update ==================================================================================================================================================
id: anidb-8692, title: Sword Art Online, lang: en, force: True, movie: False
-------------------------------------------------------------------------------------------------------------------------------------------------------------
AnimeLists.GetMetadata() - AniDBid: 8692, TVDBid: 259640, defaulttvdbseason: 1, episodeoffset: 0, name: Sword Art Online
anidbTvdbMapping() - mappingList: {'defaulttvdbseason': '1', 'name': 'Sword Art Online', 'episodeoffset': '0'}
Exception in the update function of agent named 'HamaTV', called with guid 'com.plexapp.agents.hama://anidb-8692?lang=en' (most recent call last):
File "F:\Program Files\Plex\Plex Media Server\Resources\Plug-ins-1046ba85f\Framework.bundle\Contents\Resources\Versions\2\Python\Framework\api\agentkit.py", line 1076, in _update
agent.update(obj, media, lang, **kwargs)
File "P:\Storage\Plex Media Server\Plug-ins\Hama.bundle\Contents\Code\__init__.py", line 121, in update
def update (self, metadata, media, lang, force ): Update (metadata, media, lang, force, False)
File "P:\Storage\Plex Media Server\Plug-ins\Hama.bundle\Contents\Code\__init__.py", line 99, in Update
dict_AniDB, ANNid, MALid = AniDB.GetMetadata(media, movie, error_log, source, AniDBid, TVDBid, AniDBMovieSets, mappingList)
File "P:\Storage\Plex Media Server\Plug-ins\Hama.bundle\Contents\Code\AniDB.py", line 34, in GetMetadata
full_array = [ anidbid for season in Dict(mappingList, 'TVDB') for anidbid in Dict(mappingList, 'TVDB', season) if 'e' not in season and anidbid.isdigit() ]
File "F:\Program Files\Plex\Plex Media Server\Resources\Plug-ins-1046ba85f\Framework.bundle\Contents\Resources\Versions\2\Python\Framework\code\sandbox.py", line 107, in <lambda>
_getiter_ = lambda x: x.__iter__(),
AttributeError: 'str' object has no attribute '__iter__'
Serializing to P:\Storage\Plex Media Server\Metadata\TV Shows\f\fb6ee0aca1e4a07557fbc8f7ecfbd2868e6b892.bundle\Contents\com.plexapp.agents.hama\Info.xml
Sending packed state data (104 bytes)
Response: [200] str, 16 bytes
200 GET /:/plugins/com.plexapp.agents.hama/messaging/function/X0FnZW50S2l0OlVwZGF0ZU1ldGFkYXRh/Y2VyZWFsMQoxCmxpc3QKMApyMAo_/Y2VyZWFsMQoxCmRpY3QKMTAKczIKZW5zNApsYW5nYjFzNQpmb3JjZWIwczgKcGVyaW9kaWNzNAo1MzgzczQKZGJpZGkwCnM3CnZlcnNpb25uczEwCnBhcmVudEdVSURuczgKcGFyZW50SURzNwpUVl9TaG93czEwCm1lZGlhX3R5cGVzNDQKY29tLnBsZXhhcHAuYWdlbnRzLmhhbWE6Ly9hbmlkYi04NjkyP2xhbmc9ZW5zNApndWlkczEwCmFuaWRiLTg2OTJzMgppZHIwCg__ (127.0.0.1) 1735.00ms
2018-04-01 15:30:12,108 (274c) : INFO (logkit:16) - === Update ==================================================================================================================================================
2018-04-01 15:30:12,108 (274c) : INFO (logkit:16) - id: tvdb-259640, title: Sword Art Online, lang: en, force: True, movie: False
2018-04-01 15:30:12,108 (274c) : INFO (logkit:16) - -------------------------------------------------------------------------------------------------------------------------------------------------------------
2018-04-01 15:30:12,121 (274c) : INFO (logkit:16) - AnimeLists.GetMetadata() - AniDBid: 8692, TVDBid: 259640, defaulttvdbseason: 1, episodeoffset: 0, name: Sword Art Online
2018-04-01 15:30:12,121 (274c) : INFO (logkit:16) - AnimeLists.GetMetadata() - [!] anidbseason: 0, tvdbseason: 0, start: None, end: None, offset: 0, text: ;10-0;11-0;12-0;
2018-04-01 15:30:12,124 (274c) : INFO (logkit:16) - AnimeLists.GetMetadata() - AniDBid: 10022, TVDBid: 259640, defaulttvdbseason: 0, episodeoffset: 0, name: Sword Art Online: Extra Edition
2018-04-01 15:30:12,124 (274c) : INFO (logkit:16) - AnimeLists.GetMetadata() - [!] anidbseason: 0, tvdbseason: 0, start: None, end: None, offset: 0, text: ;1-11;
2018-04-01 15:30:12,125 (274c) : INFO (logkit:16) - AnimeLists.GetMetadata() - [!] anidbseason: 1, tvdbseason: 0, start: None, end: None, offset: 0, text: ;1-10;
2018-04-01 15:30:12,125 (274c) : INFO (logkit:16) - AnimeLists.GetMetadata() - AniDBid: 10376, TVDBid: 259640, defaulttvdbseason: 2, episodeoffset: 0, name: Sword Art Online II
2018-04-01 15:30:12,125 (274c) : INFO (logkit:16) - AnimeLists.GetMetadata() - [!] anidbseason: 0, tvdbseason: 0, start: 1, end: 10, offset: 11, text: None
2018-04-01 15:30:12,142 (274c) : INFO (logkit:16) - anidbTvdbMapping() - mappingList: {'TVDB': {'s2': {'10376': '0'}, 's1': {'8692': '0'}, 's0': {'10022': '0'}, 's0e21': ('0', 10, '10376'), 's0e20': ('0', 9, '10376'), 's0e0': ('0', '12', '8692'), 's0e14': ('0', 3, '10376'), 's0e15': ('0', 4, '10376'), 's0e16': ('0', 5, '10376'), 's0e17': ('0', 6, '10376'), 's0e10': ('1', '1', '10022'), 's0e11': ('0', '1', '10022'), 's0e12': ('0', 1, '10376'), 's0e13': ('0', 2, '10376'), 's0e18': ('0', 7, '10376'), 's0e19': ('0', 8, '10376')}}
2018-04-01 15:30:12,142 (274c) : INFO (logkit:16) - -------------------------------------------------------------------------------------------------------------------------------------------------------------
Working using tvdbid You have an anidbid with 2 season folderst, it doesn't search anidb then...
I forced the AniDB id and surely i got the same issue so at least it is easier for me to resolve...
Now the poster issue we get on first refresh: GetMeta(TheTVDB', art) return False, hence skipping. downloaded[field]>0 is the culprit. it seems it never resets and it's a glabal range variable...
Please try new version released now, should solve both issues
Hello there,
Just refreshed Metadata on the situation above (folder called Sword Art Online
and then just Season 01
and Season 02
inside of it):
Season 2 metadata seems to work fine now just like Season 1, episodes have correct name plus summary:
Below is the log from this refresh in Sword Art Online.agent-update.log
Did notice an issue with the season images though after I removed and re-added the series to check if it worked like that. I refreshed three times and the poster and season images are all the same:
The log is pretty big, so I put it in a pastebin: https://pastebin.com/jUCt45g1
This is basically 3 refreshes or something. The series and season poster don't seem to change anymore regardless and just stay all the same. Not sure if intended.
Addendum: it seems I've lost a lot of posters, used to be way more than 3.
Poster priority if changing only appears if series removed and re-added like here, make it tricky to test as you need to do the removal, clean bundles, etc... Not intended, reproduced it. We had 3 bugs:
Thanks, as i have solved many issues in a single day. Please update to the version just posted and report any issues
Refreshed the metadata on the above:
Log from Sword Art Online.agent-update.log
above: https://pastebin.com/viHwnTyd
Seems the season posters got fixed and more selection for the series poster than before, although not as much as in the past (there used to be a few more, but that's minor at most).
Now removing and re-adding, at first I was missing posters:
Log from Sword Art Online.agent-update.log
at adding the stuff (not refreshed manually yet): https://pastebin.com/aFJLxz8B
After a manual metadata refresh, still no posters:
Log from Sword Art Online.agent-update.log
after a manual refresh and no posters showed up: https://pastebin.com/ZFn8Qk8Y
Edit: It seems it's also missing all banners and backgrounds as well, aside from the posters.
Hope this gives you a bit more info and thanks for all the changes/updates so far. 👍
Same bug, the download count doesn't reset even though it did for me forgot to put global should work now Please test and report, we are nearly there...
Hello there,
Refreshed metadata on the above situation (no posters) and posters showed up:
Did notice the amount of posters I can choose from series-wise is even smaller than before (used to be 7, then became 3 and now 2):
The Sword Art Online.agent-update.log
file as usual: https://pastebin.com/c7aRFskW
Removed and re-added the series from scratch (after cleaning bundles and emptying trash), result was it loads episode information and the like but no posters again:
Log as per usual: https://pastebin.com/htc9rV5Z
After refreshing the metadata manually, still no change:
Log: https://pastebin.com/QRcdG2mT
It seems it worked for a moment before, but after all the cleaning and re-adding it once again stopped doing what it should as before.
GetMeta(TheTVDB', posters) return False, hence skiping TheTVDB.GetMetadata() - Images - Posters : 0/21, Season posters: 0/15, Art: 0/40 download variable doesn't reset. will need to remove or make it a local variable...
Will need to sleep on it and recheck tomorrow 19h00 uk time the code
Take your time, have a good night.
Oh, it seems the https://github.com/ZeroQI/Hama.bundle/commit/35ea5c57c411845b8a1d960ce2df997a361d1866 commit wasn't pushed when I tested this..
I've gone ahead and tested it now and can confirm it generates posters in all cases now:
This is the Sword Art Online.agent-update.log
log on removing and re-adding the series: https://pastebin.com/iuRS7znM
The only issue I still see is, as I mentioned before, the amount of posters the series itself seems to have now. It went from about 7 to 3 and is now 2:
Not sure if it's intended, but 7 to 2 is a pretty noticeable decrease of course.
Thanks for letting me now. Do you have 'Fetch a single picture' ticked in agent settings ? Please un-tick and confirm the number of posters after a refresh If that solved, should i remove this option according to youu since only miniatures are downloaded unless needed?
Hello there,
Unticked 'Fetch a single picture' and did a manual metadata refresh on SAO:
What I noticed is that it took me about 4 minutes to really load them and that the update log was sort of 'stuck' for a while on every jpg in these lines:
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d70289de4b9.jpg'
common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42305.jpg', directory absent.
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53db475d1eada.jpg'
common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42463.jpg', directory present
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-541cb742d46eb.jpg'
common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/44870.jpg', directory present
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d7014cbcc32.jpg'
common.SaveFile() - Exception: <urlopen error ('_ssl.c:574: The handshake operation timed out',)>, url: 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d7014cbcc32.jpg'
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d701a516e7f.jpg'
common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42304.jpg', directory present
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d7017279fe3.jpg'
common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42302.jpg', directory present
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d919078cc05.jpg'
common.SaveFile() - Exception: <urlopen error timed out>, url: 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d919078cc05.jpg'
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53dd2c33c6f55.jpg'
common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42532.jpg', directory present
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d70189d2c68.jpg'
common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42303.jpg', directory present
Sword Art Online.agent-update.log
as usual: https://pastebin.com/LDm5eijx
I guess it did solve the issue, but the slowness of this compared to the past is a bit weird. It may be intended for all I know, but I figured it's something I should mention. I'm sure you can see if everything looks in order log-wise.
Mostly because of the above I'm not sure if the option should be removed, considering I can see people not caring about posters but maybe getting annoyed at the extra 4-5 minutes of metadata load time? That's up to you to decide.
You might want to clean bundles and optimize database, as that is I believe a Plex issue. Thanks a lot, the agent is useable again thanks to you as I have no time to troubleshoot thoroughly so that helped to know which series had issues.
On Mon, 2 Apr 2018 13:24 DJScias, notifications@github.com wrote:
Hello there,
Unticked 'Fetch a single picture' and did a manual metadata refresh on SAO: [image: image] https://user-images.githubusercontent.com/439655/38196078-3f6cf152-3681-11e8-8ab3-7d1e8129bb96.png
What I noticed is that it took me about 4 minutes to really load them and that the update log was sort of 'stuck' for a while on every jpg in these lines:
Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d70289de4b9.jpg' common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42305.jpg', directory absent. Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53db475d1eada.jpg' common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42463.jpg', directory present Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-541cb742d46eb.jpg' common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/44870.jpg', directory present Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d7014cbcc32.jpg' common.SaveFile() - Exception: <urlopen error ('_ssl.c:574: The handshake operation timed out',)>, url: 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d7014cbcc32.jpg' Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d701a516e7f.jpg' common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42304.jpg', directory present Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d7017279fe3.jpg' common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42302.jpg', directory present Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d919078cc05.jpg' common.SaveFile() - Exception:
, url: 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d919078cc05.jpg' Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53dd2c33c6f55.jpg' common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42532.jpg', directory present Requesting 'https://assets.fanart.tv/fanart/tv/259640/showbackground/sword-art-online-53d70189d2c68.jpg' common.SaveFile() - CachePath: 'P:\Storage\Plex Media Server\Plug-in Support\Data\com.plexapp.agents.hama\DataItems', file: 'FanartTV/tv/259640259640/showbackground/42303.jpg', directory present Sword Art Online.agent-update.log as usual: https://pastebin.com/LDm5eijx
I guess it did solve the issue, but the slowness of this compared to the past is a bit weird. It may be intended for all I know, but I figured it's something I should mention. I'm sure you can see if everything looks in order log-wise.
Mostly because of the above I'm not sure if the option should be removed, considering I can see people not caring about posters but maybe getting annoyed at the extra 4-5 minutes of metadata load time? That's up to you to decide.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ZeroQI/Hama.bundle/issues/177#issuecomment-377918719, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7LZXR-1ojF7rP7Fr46dzE_blu4kvV_ks5tkhhhgaJpZM4TAZEM .
@ZeroQI What should the expected behavior of the Single Poster checkbox be when it is checked and not checked? Just want to know while I’m testing later.
it should download one poster per meta source but i relaxed restrictions for season posters so you can have multiple
Hello there,
I cleaned my bundles (always do this, to be fair) but also optimized the database and then removed and re-added SAO and it worked just fine now with this series.
However I have noticed that mostly in SAO's case if you use "Single Poster" that the series posters only have 2 so I'm not sure if people would want this on by default. I mean, the sole reason you use Plex is because you care about a more better looking front-end idea for your video files.. Considering otherwise you'd just leave it in your folders and don't care about it. I can see how plex users would want more than two posters in that case.
Regardless, the main issues of Ao no Exorcist and Sword Art Online (except the "Single Poster" stuff) seems to be all in order which means that the underlying issue here was fixed. Good job!
I'll be sure to make a new issue (or add to this if it's still open) when I run into a different series with issues.
Excellent. Might remove the 'get single poster' setting since thumbs are downloaded anyway before the full poster is...
Hello there,
So far the beta agent (commit: daca9210e8649ec10fd93e4a51ebf7c840c8f3a2) has worked like a charm (except some issues with SAO but I read about that, I'll wait for a proper fix regarding that).
However I can't seem to get Ao no Exorcist (Blue Exorcist) linking decently.
It's staying like this, even after all the times I try to re-match it with
[anidb-8148]
and refreshing the metadata:I've gone and checked the
Ao no Exorcist.agent-update.log
file and noticed, unlike the others, that it had an error in it:I deeply apologize if this is a duplicate or the like, I'm mostly just curious why the error is happening and how I can fix Ao no Exorcist loading.
Regards.