ZeroQI / Hama.bundle

Plex HTTP Anidb Metadata Agent (HAMA)
GNU General Public License v3.0
1.21k stars 113 forks source link

Locked (edited) fields are overwritten when applying anidb mapping #555

Closed efalsken closed 1 year ago

efalsken commented 1 year ago

As discussed in this Absolute-Series-Scanner thread:

The previously-locked metadata has been overwritten with fresh data from Anidb.... ignoring the "locked" flag on the field and my previous edits. This does not match the expected behavior: image

ZeroQI commented 1 year ago

So Plex ignore the lock icon, and somehow it's the agent problem? I don't get it... You even documented from Plex knowledge base their own behaviour...

The agent does NOT manage anything to do with locking... It provides the metadata and Plex use it and here messed up...

efalsken commented 1 year ago

I was looking at the responsibilities documented here: https://github.com/ZeroQI/Absolute-Series-Scanner/blob/master/README.md#plex-agent-responsibilities

I'm not sure if it's Plex, the Scanner, or the Agent which is responsible for honoring the Lock. The lock works when using "refresh metadata" but not when matching. It works as intended if I rename a folder in a Plex-Scanner library. But not when using Absolute-Series-Scanner and Hama.

I think this has something to do between the scanner and plex..... When watching the library folder I can see the "newly renamed" folder show up as a new series.... but the image and data will be empty. Then the "old" one is removed (not just marked with the "trash" icon). Then the metadata is fetched. So somewhere between the detection, identification and matching, the old metadata and edits are lost..... but the watch history is maintained. Then the metadata is downloaded and applied to the now-fresh series.

ZeroQI commented 1 year ago

The agent provide an array of metadata to plex. It does not handle locks, that's a Plex decision. Now if you change the folder and it gets a different unique ID I would understand it lose the lock information, but that's not the case here... I can safely say the lock is a Plex behaviour and not in scanner or agent responsability...

efalsken commented 1 year ago

Can you help me report this as a bug then to Plex? I don't think I have enough detail since this involves plugins.

ZeroQI commented 1 year ago

I have no contact or relations or even a Plex pass...

It does NOT involve an agent though... You lock a field, and plex update it when it shouldn't since it Was locked... The metadata field provided by the agent is irrelevant since The agent is unaware of field locked, it return the metadata structure identically regardless....