ZeroQI / YouTube-Agent.bundle

Plex Metadata Agent for Movies and TV Series libraries
452 stars 43 forks source link

Channels don't show their true channel name #80

Closed reddragonguy closed 3 years ago

reddragonguy commented 3 years ago

Hi,

I just have a video file /media/youtube/Emergency_Awesome [UCDiFRMQWpcp8_KD4vwIVicw]/20210317 - Justice_League_Snyder_Cut_Trailer_-_Darkseid_Kills_The_Justice_League_and_Green_Lantern_Breakdown [qwtK4BDw1Pw].mp4 and the channel name is set to Emergency_Awesome instead of Emergency Awesome.

Shouldn't the channel name from YouTube override the channel name that was generated from the folder?

ZeroQI commented 3 years ago

If a user creates several series folder with videos from the same channel because there is no playlist available, it makes no sense to label each series with the channel name. If gives the name of the folder for that reason...

reddragonguy commented 3 years ago

I'm sorry, i don't think i understand your reply. there's only one folder for one channel and one show. When using the option of --restrict-filenames, yt-dl will replace spaces with dashes as my example shows above. The TV show that's created should have the channel name instead of the folder name with the underscore, shouldn't it?

ZeroQI commented 3 years ago

Users have the right to have multiples series folders taken from the same channel (if there is no playlist for example):

Forcing the same channel name would group all, which is not desired, furthermore some user may not want to label the series created as per the channel name.

Why do you use "--restrict-filenames"? It does restrict filenames to only ASCII characters, and avoid "&" and spaces in filenames, but these don't cause issues to my knowledge (it does in folder name though)

reddragonguy commented 3 years ago

it's an all-or-none situation. I have the issue with that shows up in the folder name and to resolve it automatically, i changed the script to use --restrict-filenames. It may be overkill for the one folder i'm aware of, but if i add other channels that have non-acceptable characters in their channel name or video titles, I know it'll be handled. I can't tell it which characters to keep and which characters to replace. I use the --batch-file FILE to get all channels at once, so it'll end up changing all characters in all folders and filenames.

I understand the reasoning, but it seems like it should be a specified option rather than assumption of the code. IMHO, I'd assume, by default, the metadata would always be used since the channel id is part of the folder name and a setting should/could be specified to "ask" for different behavior. Like a json or ini file with a setting `KeepFolderNameAsChannelName = true". But it's your tool and I don't mean to intrude on your design and force any kind of change.

Again, thank you for what you've done so far and the great addition to Plex.

ZeroQI commented 3 years ago

Fair enough for --restrict filenames, would have done the same...

i could replace underscores with spaces, that is fine I try to keep the code short and simple as it's complex enough (json, api for playlist, channel, etc..)