search

ZeroXNoxus / dark-mode-5e

2 stars 0 forks source link

Music Playlists Overlapping #29

Closed whenbearsreign closed 2 months ago

whenbearsreign commented 4 months ago

Describe the bug When module is enabled, music playlists overlap.

To Reproduce Steps to reproduce the behavior:

  1. Create multiple playlists
  2. Turn on Dark Mode module

Screenshots image

Game Specifics (please complete the following information):

ZeroXNoxus commented 4 months ago

@whenbearsreign I can sadly not reproduce this issue and my module does not touch the playlists in any way. Please make sure that no other module is changing anything in the playlist tab. image

whenbearsreign commented 4 months ago

@whenbearsreign I can sadly not reproduce this issue and my module does not touch the playlists in any way. Please make sure that no other module is changing anything in the playlist tab. image

Thanks for the reply. I am testing with only Dark Mode enabled and getting the same result as my original post. This is the only error I see in the console. It references "Dark-Mode" but I don't know if the console error matches with the way it's presenting.

edit: Also wanted to mention that this error is happening in both Chrome and Edge.

<html>
<body>
<!--StartFragment--><div aria-expanded="true" tabindex="-1" style="box-sizing: border-box; min-width: 0px; min-height: 0px; flex: 0 0 auto; color: rgb(227, 227, 227); font-family: consolas, &quot;lucida console&quot;, &quot;courier new&quot;, monospace; font-size: 12px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(0, 74, 119); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><span class="source-code" style="box-sizing: border-box; min-width: 0px; min-height: 0px; font-family: var(--source-code-font-family); white-space: pre-wrap; font-size: var(--source-code-font-size) !important; line-height: 1.2;"><span class="console-message-anchor" style="box-sizing: border-box; min-width: 0px; min-height: 0px; float: right; text-align: right; max-width: 100%; margin-left: 4px;"><span class="devtools-link invalid-link" tabindex="-1" title="https://foundry.url/scripts/foundry.js:753" style="box-sizing: border-box; min-width: 0px; min-height: 0px; color: var(--text-disabled); text-decoration: none; outline-offset: 2px;"><br class="Apple-interchange-newline">foundry.js:753</span> </span><span class="console-message-text" style="box-sizing: border-box; min-width: 0px; min-height: 0px; color: var(--override-error-text-color) !important;"><span class="object-value-error source-code" style="box-sizing: border-box; min-width: 0px; min-height: 0px; font-family: var(--source-code-font-family); white-space: pre-wrap; font-size: var(--source-code-font-size) !important; line-height: 1.2;"><span style="box-sizing: border-box; min-width: 0px; min-height: 0px;">TypeError: Error thrown in hooked function '' for hook 'init'. Cannot read properties of undefined (reading 'active')
<span style="box-sizing: border-box; min-width: 0px; min-height: 0px;">    at Object.fn (<span class="devtools-link" role="link" tabindex="-1" title="https://foundry.url/modules/dark-mode-5e/script/dark-mode.js:23:46" style="box-sizing: border-box; min-width: 0px; min-height: 0px; color: var(--sys-color-primary); text-decoration: underline; outline-offset: 2px; cursor: pointer; word-break: break-all;">dark-mode.js:23:46</span>)
</span><span style="box-sizing: border-box; min-width: 0px; min-height: 0px;">    at #call (<span class="devtools-link" role="link" tabindex="-1" title="https://foundry.url/scripts/foundry.js:730:20" style="box-sizing: border-box; min-width: 0px; min-height: 0px; color: var(--sys-color-primary); text-decoration: underline; outline-offset: 2px; cursor: pointer; word-break: break-all;">foundry.js:730:20</span>)
</span><span style="box-sizing: border-box; min-width: 0px; min-height: 0px;">    at Hooks.callAll (<span class="devtools-link" role="link" tabindex="-1" title="https://foundry.url/scripts/foundry.js:687:17" style="box-sizing: border-box; min-width: 0px; min-height: 0px; color: var(--sys-color-primary); text-decoration: underline; outline-offset: 2px; cursor: pointer; word-break: break-all;">foundry.js:687:17</span>)
</span><span style="box-sizing: border-box; min-width: 0px; min-height: 0px;">    at Game.initialize (<span class="devtools-link" role="link" tabindex="-1" title="https://foundry.url/scripts/foundry.js:8635:11" style="box-sizing: border-box; min-width: 0px; min-height: 0px; color: var(--sys-color-primary); text-decoration: underline; outline-offset: 2px; cursor: pointer; word-break: break-all;">foundry.js:8635:11</span>)
</span><span style="box-sizing: border-box; min-width: 0px; min-height: 0px;">    at window.addEventListener.once (<span class="devtools-link" role="link" tabindex="-1" title="https://foundry.url/scripts/foundry.js:91833:26" style="box-sizing: border-box; min-width: 0px; min-height: 0px; color: var(--sys-color-primary); text-decoration: underline; outline-offset: 2px; cursor: pointer; word-break: break-all;">foundry.js:91833:26</span>)</span></span></span></span></span></div><div class="" role="group" style="box-sizing: border-box; min-width: 0px; min-height: 0px; flex: 0 0 auto; color: rgb(227, 227, 227); font-family: consolas, &quot;lucida console&quot;, &quot;courier new&quot;, monospace; font-size: 12px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(0, 74, 119); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><span class="monospace stack-preview-container" style="display: inline-block; width: 483px; --monospace-font-size: 12px; --monospace-font-family: consolas,lucida console,courier new,monospace; --source-code-font-size: 12px; --source-code-font-family: consolas,lucida console,courier new,monospace; box-sizing: border-box; min-width: 0px; min-height: 0px; font-family: var(--monospace-font-family); font-size: var(--monospace-font-size) !important;">
  | onError | @ | foundry.js:753
-- | -- | -- | --

</span></div><!--EndFragment-->
</body>
</html>
ZeroXNoxus commented 4 months ago

Hm... The error you see should not cause an issue in the styling, though I have taken care of it. For me (in Chrome, Foundry v11.315, DnD 5th Edition 3.0.3) it looks like this: image

image

Are you on the newest version of Dark Mode? This error occured before a few releases back. Please tell me the versions of FoundryVTT, DnD 5th Edition and Dark Mode so I can confirm this error.

whenbearsreign commented 4 months ago

Foundry version is 11.315, D&D 5e version 3.0.3, and Dark Mode 2.1.0.

image